C# 8 nullable reference types - Preprocessor symbols for nullable reference types #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
force-pushed
the
nullable-contexts
branch
3 times, most recently
from
71a2f3f
to
bdfd6f7
Compare
BillWagner
added a commit
to BillWagner/csharpstandard
that referenced
this pull request
May 10, 2024
Those changes have been moved to dotnet#1108
|
I saw "preprocessor symbols" and thought it meant "conditional compilation symbols". |
BillWagner
added
the
meeting: discuss
|
This should be discussed before #1105. It's shorter and simpler. |
jskeet
approved these changes
May 15, 2024
| @@ -1025,7 +1025,7 @@ right_shift_assignment | |||
|
|
|||
| ### 6.5.1 General | |||
|
|
|||
| The pre-processing directives provide the ability to conditionally skip sections of compilation units, to report error and warning conditions, and to delineate distinct regions of source code. | |||
| The pre-processing directives provide the ability to conditionally skip sections of compilation units, to report error and warning conditions, to delineate distinct regions of source code, and to set the nullable context. | |||
There was a problem hiding this comment.
Suggested change
| The pre-processing directives provide the ability to conditionally skip sections of compilation units, to report error and warning conditions, to delineate distinct regions of source code, and to set the nullable context. | |
| The pre-processing directives provide the ability to conditionally skip sections of compilation units, to report error and warning conditions, to delineate distinct regions of source code, and to set the nullable contexts. |
(Given that we're using the plural form later.)
Alternatively, we could decide we have a single nullable context, which has properties for both warnings and annotations.
|
Meeting notes:
|
The first commit ports in the text from dotnet#700 substantially without change. The only editorial change is to move the clause on "Nullable directives" in lexical-structure before the clause on Pragma directives. In addition, it fixes build warnings
Remove an Xref to a section that's not in this PR.
BillWagner
force-pushed
the
nullable-contexts
branch
from
5b2db00
to
76fd168
Compare
BillWagner
added a commit
to BillWagner/csharpstandard
that referenced
this pull request
May 29, 2024
Alternative PR to dotnet#1108. This branch builds on the work in dotnet#1108. This is an alternative approach that defines a single `nullable` context. The nullable context has two properties: `annotations` and `warnings` that can be enabled or disabled separately.
|
closing this PR in favor of #1123 |
BillWagner
added a commit
that referenced
this pull request
Jul 10, 2024
…llable context. (#1123) * Port text from #700 The first commit ports in the text from #700 substantially without change. The only editorial change is to move the clause on "Nullable directives" in lexical-structure before the clause on Pragma directives. In addition, it fixes build warnings * Remove link (which will need to get added) Remove an Xref to a section that's not in this PR. * Define a single nullable context Alternative PR to #1108. This branch builds on the work in #1108. This is an alternative approach that defines a single `nullable` context. The nullable context has two properties: `annotations` and `warnings` that can be enabled or disabled separately. * Update per meeting comments in review This commit addresses all online feedback. * Respond to feedback from June meeting I listened to the June meeting. I updated a bit of text, and added Jon's example from the conversation. * Update lexical-structure.md * Apply suggestions from code review * Update standard/lexical-structure.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #1105
Fixes #1088
Separate the portion of 1105 that defines the nullable context. This includes only the preprocessor symbols, update to one introductory sample, and a related fix that updates one sample test.