Add status checks to the word converter #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
reviewed
Jun 25, 2024
Not yet. I wanted to check the shell script updates first. |
Add the code to upload check results from the word converter
BillWagner
commented
Jun 26, 2024
|
This is now ready. |
|
Will look tomorrow morning UK time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add status checks to the Word converter.
Since this also drives some changes on the shell script, so fix the hack in #1134 with more reasonable shell programming.
Contributes to #1125
The bulk of the changes are hooking up the reporter type to the new status check library. The reporter already does most of the work to report errors and warnings.
The final set of changes is to replace the hardcoded strings with constants for diagnostic ids.