Minor changes to address issues found in #806 #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
reviewed
Jun 19, 2023
Closed
jskeet
commented
Jul 3, 2023
There was a problem hiding this comment.
@BillWagner It would be good to get the uncontroversial bits of this in before next week's meeting - PTAL; I'm happy to remove any changes that we think still need more work.
Nigel-Ecma
reviewed
Jul 3, 2023
Nigel-Ecma
requested changes
Jul 12, 2023
There was a problem hiding this comment.
One issue left to resolve, I’ve express a slight preference but either option suggested by @jskeet is fine. Then it’s good to go/
gafter
approved these changes
Jul 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were found comparing @gafter's gist with the current content. There are a couple of outstanding items which we can address separately.