Enhancements to NETCore.Client and dotnet-dump around ports and logging #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hoyosjs
commented
May 15, 2023
hoyosjs
commented
- Add support for collecting dumps of apps using alternative ports.
- Update IPC spec for all generate dump commands.
- Add option for collecting verbose logging from dotnet-dump.
- Pipe logging capability to a file through dotnet-dump.
mikem8361
reviewed
May 15, 2023
| @@ -149,6 +153,10 @@ NotSupportedException or | |||
| DiagnosticsClientException) | |||
| { | |||
| console.Error.WriteLine($"{ex.Message}"); | |||
| if (config.LogLevel == LogLevelOption.None) | |||
| { | |||
| console.Error.WriteLine($"Consider rerunning the command with diagnostic output enabled."); | |||
There was a problem hiding this comment.
I think there should be a dash in "re-running".
mikem8361
reviewed
May 15, 2023
| @@ -49,31 +63,69 @@ public static Task<int> Main(string[] args) | |||
| aliases: new[] { "-n", "--name" }, | |||
| description: "The name of the process to collect a memory dump.") | |||
| { | |||
| Argument = new Argument<string>(name: "name") | |||
| Name = nameof(DumpCollectionConfig.ProcessName), | |||
| Argument = new Argument<string>(name: "ProcessName") | |||
There was a problem hiding this comment.
You are not consistent with using nameof() for the Argument name
mikem8361
reviewed
May 15, 2023
| }; | ||
|
|
||
| private static Option CrashReportOption() => | ||
| new( | ||
| alias: "--crashreport", | ||
| description: "Enable crash report generation.") | ||
| { | ||
| Name = nameof(DumpCollectionConfig.GenerateCrashReport), | ||
| Argument = new Argument<bool>(name: "crashreport") |
There was a problem hiding this comment.
Not consistent with using nameof(DumpCollectionConfig.GenerateCrashReport) here, but it is ok if it affects the --help text.
mikem8361
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.