-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Markdown xref broken for external xrefmap.yml #9866
Comments
@glopesdev It's expected be released same timing with #9824 changes. If it's not using Please provide example xrefmap that cause problems. |
@filzrev this doesn't use redirection (or at least not intentionally. I didn't even know this feature existed until now), both projects use mostly default docfx settings. Example xrefmap: https://horizongir.github.io/ZedGraph/xrefmap.yml |
@glopesdev It seems xrefmap define |
@filzrev I have updated the issue to clarify that
I am not sure I understand the rationale for this. These are not local Also if this is the case then there is a breaking change which should be documented more clearly since as I mentioned in the issue the behavior changes if we downgrade to 2.75.3 where these external references are resolved correctly to the external website URL. |
Thanks for your reply. I've confirmed it can reproduce problems when specify xrefmap with URLs. It's regression introduced by my PR commit.
Previous implementation converting all I'll create fix PR later as soon as possible with relating tests. |
fix: xrefmap baseurl problems
fix: xrefmap baseurl problems
This is a regression in 2.76.0. Confirmed that the same reference resolves fine in 2.75.3 so we are downgrading for the time being.
Markdown cross-references in articles pointing to UIDs defined in external
xrefmap.yml
files are resolved as if they are internal API references. For example:[OtherClass](xref:External.Namespace.OtherClass)
will resolve tohttp://mydomain.org/api/External.Namespace.OtherClass.html
instead ofhttp://externaldomain.org/api/External.Namespace.OtherClass.html
.To Reproduce
Steps to reproduce the behavior:
xref
section todocfx.json
containing a URL to axrefmap.yml
in another domain.Expected behavior
Cross-references should resolve to links pointing to the external website.
Context (please complete the following information):
Additional context
Downgrading to 2.75.3 fixes the problem.
The text was updated successfully, but these errors were encountered: