Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dotnet new details command #35919

Merged
merged 7 commits into from
Jul 12, 2023
Merged

Dotnet new details command #35919

merged 7 commits into from
Jul 12, 2023

Conversation

maridematte
Copy link
Contributor

@maridematte maridematte commented Jun 22, 2023 •
edited by github-actions bot
Loading

Summary

Added a new page for the dotnet new details command that was implemented here: dotnet/sdk#31743.

Internal previews

📄 File 🔗 Preview link
docs/core/tools/dotnet-new-details.md docs/core/tools/dotnet-new-details

@dotnet-bot dotnet-bot added this to the June 2023 milestone Jun 22, 2023
@maridematte maridematte mentioned this pull request Jun 22, 2023
Open
4 tasks
@maridematte maridematte marked this pull request as ready for review July 7, 2023 13:47
tdykstra
tdykstra reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few minor suggestions, and the article needs to be added to the toc.yml file.

docs/core/tools/dotnet-new-details.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-new-details.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-new-details.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-new-details.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-new-details.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-new-details.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-new-details.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-new-details.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-new-details.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-new-details.md Outdated Show resolved Hide resolved
vlada-shubina
vlada-shubina requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove --version due to dotnet/templating#6811

docs/core/tools/dotnet-new-details.md Outdated Show resolved Hide resolved
docs/core/tools/dotnet-new-details.md Outdated Show resolved Hide resolved
@BillWagner BillWagner modified the milestones: June 2023, July 2023 Jul 11, 2023
@maridematte maridematte requested a review from a team as a code owner July 11, 2023 16:23
vlada-shubina
vlada-shubina approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@maridematte maridematte reopened this Jul 12, 2023
@tdykstra tdykstra merged commit 73a8bea into dotnet:main Jul 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

@vlada-shubina vlada-shubina vlada-shubina approved these changes

Assignees
No one assigned
Labels
cli/subsvc dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2023
Development

Successfully merging this pull request may close these issues.
5 participants
@maridematte @tdykstra @vlada-shubina @BillWagner @dotnet-bot