Update zip archive append example #8244
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this example should leverage
ZipArchiveMode.Create
because it is only appending/writing to entries.Create
is more efficient in that scenario since it does not have to buffer the entire archive in memory. Furthermore, it is confusing thatZipArchiveMode.Create
supports appending (unlikeFile.Create
/FileMode.Create
), so calling this nuance out in the first code example seems prudent.See dotnet/runtime#49149