Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin Microsoft.Extensions.Caching.Memory and Microsoft.Extensions.Logging #25323

Closed
wants to merge 2 commits into from

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jul 23, 2021

Fixes #25148

@mmitche mmitche requested a review from dougbu as a code owner July 23, 2021 15:48
@mmitche mmitche requested a review from bricelam July 23, 2021 15:48
@mmitche mmitche changed the title Unpin dependencies Unpin Microsoft.Extensions.Caching.Memory and Microsoft.Extensions.Logging Jul 23, 2021
@mmitche
Copy link
Member Author

mmitche commented Jul 23, 2021

@bricelam Legit failures here..can you take a look?

@ajcvickers
Copy link
Member

@mmitche Looks like the dependency update brought in breaking changes. Are these intentional? If so, where can we find more information?

@mmitche
Copy link
Member Author

mmitche commented Jul 23, 2021

@mmitche Looks like the dependency update brought in breaking changes. Are these intentional? If so, where can we find more information?

I'm not sure... https://docs.microsoft.com/en-us/dotnet/api/system.span-1.copyto?view=net-5.0 seems to indicate that CopyTo is netstandard 2.1...so something else is going on.

@mmitche
Copy link
Member Author

mmitche commented Jul 23, 2021

@ajcvickers I have a hunch and am attempting to update to the p6 sdk.

Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: Why was an Arcade update needed❔

@dougbu
Copy link
Member

dougbu commented Jul 23, 2021

I thought @bricelam already reacted to logging API changes in this repo❔

      Application startup exception
      System.TypeInitializationException: The type initializer for 'Microsoft.AspNetCore.Mvc.MvcCoreLoggerExtensions' threw an exception.
       ---> System.MissingMethodException: Method not found: 'System.Action`4<Microsoft.Extensions.Logging.ILogger,!!0,!!1,System.Exception> Microsoft.Extensions.Logging.LoggerMessage.Define(Microsoft.Extensions.Logging.LogLevel, Microsoft.Extensions.Logging.EventId, System.String, Boolean)'.
         at Microsoft.AspNetCore.Mvc.MvcCoreLoggerExtensions..cctor()
         --- End of inner exception stack trace ---
         at Microsoft.AspNetCore.Mvc.ModelBinding.ModelBinderFactory..ctor(IModelMetadataProvider metadataProvider, IOptions`1 options, IServiceProvider serviceProvider) in Microsoft.AspNetCore.Mvc.Core.dll:token 0x6000629+0x35
         at System.RuntimeMethodHandle.InvokeMethod(Object target, Span`1& arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)
         at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in System.Private.CoreLib.dll:token 0x6004eca+0x63

Might need newer ASP.NET bits too

@mmitche
Copy link
Member Author

mmitche commented Jul 23, 2021

Just curious: Why was an Arcade update needed❔

It was a hunch based on one of the previous errors (a missing method exception). I thought there may be a mismatch between the runtime that tests were executing on and the compiled code. It did actually resolve that exception.

@bricelam
Copy link
Contributor

Duplicate of #25244

@bricelam bricelam marked this as a duplicate of #25244 Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removed pinned dependency to Microsoft.Extensions.Caching.Memory.
5 participants