[release/9.0] Change some JSON Metadata API to respect null values set explicitly. #34624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ropertyName to respect null values set explicitly. Fixes #34434
artl93
approved these changes
Sep 5, 2024
|
@dotnet/efteam Ping |
roji
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34434
Description
This is a follow up to #34401 (review)
GetContainingPropertyName,GetContainerColumnNameandGetJsonPropertyNamedidn't respect thenullvalue from the annotation and still calculated a default value. This change makes the behavior consistent with other similar API.Customer impact
It's currently unlikely for a customer to hit this as they would need to set the annotation value explicitly, but it might be useful in some workarounds if new issues are discovered in this area.
How found
PR review
Regression
No
Testing
Tests added.
Risk
Low.