Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FieldAwareFactorizationMachines trainer can't have any empty arguments list #2927

Closed
rogancarr opened this issue Mar 12, 2019 · 0 comments
Closed

FieldAwareFactorizationMachines trainer can't have any empty arguments list #2927

rogancarr opened this issue Mar 12, 2019 · 0 comments
Assignees
@rogancarr
Labels
API Issues pertaining the friendly API

Comments

@rogancarr
Copy link
Contributor

The FieldAwareFactorizationMachines trainer cannot be given an empty arguments list.

var ffmTrainer = mlContext.BinaryClassification.Trainers.FieldAwareFactorizationMachine(
    new FieldAwareFactorizationMachineBinaryClassificationTrainer.Options { });

or

var ffmTrainer = mlContext.BinaryClassification.Trainers.FieldAwareFactorizationMachine(
    new string[] {"Features"});

I suggest allowing an empty arguments list by default. cc @sfilipi
@rogancarr rogancarr added the API Issues pertaining the friendly API label Mar 12, 2019
@rogancarr rogancarr mentioned this issue Mar 12, 2019
Merged
@rogancarr rogancarr self-assigned this Mar 12, 2019
@rogancarr rogancarr mentioned this issue Mar 12, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rogancarr rogancarr

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rogancarr