Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to supported TFMs and SDK versions #1882

Merged
merged 6 commits into from
Mar 6, 2023
Merged

Conversation

idg10
Copy link
Collaborator

@idg10 idg10 commented Mar 3, 2023

Also remove dependency on System.Runtime.InteropServices.WindowsRuntime in netstandard2.0 - this wouldn't work right on net6.0 or later because they use C#/WinRT for interop.

This enables use of current tooling such as Visual Studio 2022

Remove dependency on System.Runtime.InteropServices.WindowsRuntime in netstandard2.0 - this wouldn't work right on net6.0 or later because they use C#/WinRT for interop
@idg10 idg10 self-assigned this Mar 3, 2023
@idg10
Copy link
Collaborator Author

idg10 commented Mar 3, 2023

Note: the UWP test runner application doesn't work yet, because xUnit doesn't support UWP on Visual Studio 2022. The current plan is to address this shortly by pushing a commit that replaces xUnit with MSTest.

Visual Studio 2022 doesn't support Windows SDK 10.0.16299 - the oldest
it supports is 10.0.18362. The last version of Windows for which the
latest available surface area was 16299 (Windows 10 1709) went out of
support in April 2019. SDK 18362 started with Windows 10 1903 in May
2019 (and 1903 itself went out of support in November 2020), so this is
still a fairly old API version, accommodating some long-out-of-date
versions of Windows. This was the smallest increment that would bring us
to SDK versions supported by the current tooling.
@idg10 idg10 marked this pull request as ready for review March 6, 2023 07:05
Copy link
Collaborator

@HowardvanRooijen HowardvanRooijen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@idg10 idg10 merged commit 843927d into main Mar 6, 2023
@idg10 idg10 deleted the tooling/vs2022-net70sdk branch March 6, 2023 07:17
@idg10 idg10 mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants