Fix points pointed out and refactor

dotnet · Jul 31, 2024 · 4c3fac4 · 4c3fac4
1 parent f46613f
commit 4c3fac4
Show file tree

Hide file tree

Showing 3 changed files with 332 additions and 117 deletions.
diff --git a/src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_BinaryOperator.cs b/src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_BinaryOperator.cs
@@ -117,8 +117,7 @@ public BoundExpression VisitBinaryOperator(BoundBinaryOperator node, BoundUnaryO
  Debug.Assert(node.Type.SpecialType == SpecialType.System_String, "Non-string binary addition should have been handled by VisitConversion or VisitArguments");
  ImmutableArray<BoundExpression> parts = CollectBinaryOperatorInterpolatedStringParts(node);
  // We do not have to consider custom handlers or formatters here thanks to the above Debug.Assert, so now we have only to take expression trees into account.
- var canHideOptimization = !_inExpressionLambda;
- return LowerPartsToString(data, parts, node.Syntax, node.Type, canHideOptimization);
+ return LowerPartsToString(data, parts, node.Syntax, node.Type, usingDirectlyAsString: !_inExpressionLambda);
  }
 
  if (node.OperatorKind is BinaryOperatorKind.Utf8Addition)