New Compilation

[biqas]

Hello,

in previous Version 4.8.0 getting a compilation from a project and then removing all syntaxtrees from that compilation and adding a new syntaxtree to the same compilation (tree has no errors) has semantic errors now, before it worked. Errors are: system references are missing (like Func<>, Span<>, ...). Checking the compilation for errors before changing the trees everything is fine?!?

[333fred]

Can you please be more specific? Provide some sample code, what you expect the behavior to be, and what it is instead?

[333fred]

What is HasSemanticErrors? How is originProject created? Can you provide a complete code example?

[jasonmalinowski]

Putting @biqas's response to @333fred in a comment here:

solution comes from MSBuildWorkspace and the projects in the solution are valid projects.

originProject = solution.Projects.First();

HasSemanticErrors => semanticModel .GetDiagnostics(cancellationToken: token) .Where(x => x.Severity == DiagnosticSeverity.Error) .Select(x => x.ToString()) .ToArray().Length > 0;

and template.SyntaxTree is something like this:

using System;

Console.WriteLine();

The example is simplified so it is not exact, but the relevant parts are there.

[jasonmalinowski]

The example is simplified so it is not exact, but the relevant parts are there.

The details often matter in the world of compilers! One thing that comes to mind -- if one of the trees you removed was the tree that contained global usings, that could impact other files.

[biqas]

I guess this was in this instance the detail which mattered :), tried to just add the template.SyntaxTree and it has no Errors anymore. Thx.