Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue binding (erroneous) variables in a declarator argument list. #13460

Closed
gafter opened this issue Aug 30, 2016 · 3 comments
Closed

Issue binding (erroneous) variables in a declarator argument list. #13460

gafter opened this issue Aug 30, 2016 · 3 comments
Assignees
@AlekseyTs
Labels
Area-Compilers Bug New Language Feature - Out Variable Declaration Out Variable Declaration New Language Feature - Pattern Matching Pattern Matching Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
2.0 (RC)

Comments

@gafter
Copy link
Member

gafter commented Aug 30, 2016

In #13274 (comment) @AlekseyTs noted that the error situation of variables being declared inside a declarator argument list can have more precise binding behavior, so that some (erroneous) variables declared in that context will bind to a valid type, while others will be assigned an error type. This change would likely simplify the code.
@gafter gafter mentioned this issue Aug 30, 2016
Merged
@AlekseyTs AlekseyTs added this to the 2.0 (Preview 5) milestone Aug 31, 2016
@AlekseyTs AlekseyTs self-assigned this Aug 31, 2016
AlekseyTs added a commit to AlekseyTs/roslyn that referenced this issue Sep 1, 2016
@AlekseyTs
Properly handle expression variable declared within VariableDeclarato…
f0304e0 
…rSyntax.ArgumentList in ‘fixed’, ‘for’ and ‘using’ statements.

Related to dotnet#12597.
Fixes dotnet#13459, dotnet#13460.
@AlekseyTs AlekseyTs mentioned this issue Sep 1, 2016
Merged
@AlekseyTs AlekseyTs added 4 - In Review A fix for the issue is submitted for review. and removed 3 - Working labels Sep 1, 2016
@AlekseyTs
Copy link
Contributor

This issue has been addressed

@AndyGerlicher AndyGerlicher removed 4 - In Review A fix for the issue is submitted for review. Bug labels Sep 7, 2016
@AlekseyTs AlekseyTs added Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented labels Sep 7, 2016
@gafter
Copy link
Member Author

gafter commented Sep 8, 2016

As noted in #13660, tests are missing for this bug fix.

@gafter gafter reopened this Sep 8, 2016
@gafter gafter removed the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Sep 8, 2016
@gafter gafter modified the milestones: 2.0 (RC), 2.0 (Preview 5) Sep 8, 2016
@gafter gafter mentioned this issue Sep 8, 2016
Closed
@AlekseyTs
Copy link
Contributor

Additional testing for Patterns is tracked by #13660.

@AlekseyTs AlekseyTs added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlekseyTs AlekseyTs

Labels
Area-Compilers Bug New Language Feature - Out Variable Declaration Out Variable Declaration New Language Feature - Pattern Matching Pattern Matching Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
2.0 (RC)
Development

No branches or pull requests
3 participants
@gafter @AndyGerlicher @AlekseyTs