Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ConversionGroup #27163

Closed
cston opened this issue May 25, 2018 · 1 comment
Closed

Remove ConversionGroup #27163

cston opened this issue May 25, 2018 · 1 comment
Assignees
@cston
Labels
Area-Compilers Bug Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality New Language Feature - Nullable Reference Types Nullable Reference Types
Milestone
Compiler.Next

Comments

@cston
Copy link
Member

cston commented May 25, 2018 •
edited
Loading

Investigate removing ConversionGroup and simply walk the BoundConversion instances from initial binding in `NullableWalker.

See https:/dotnet/roslyn/pull/26356/files#r190725973.
@cston cston mentioned this issue May 25, 2018
Merged
@gafter gafter added this to the 16.0 milestone May 31, 2018
@jaredpar jaredpar added the Bug label Aug 30, 2018
@gafter gafter modified the milestones: 16.0, 16.1 Feb 26, 2019
@cston cston self-assigned this Mar 16, 2019
@jaredpar jaredpar modified the milestones: 16.1, Compiler.Next Apr 9, 2019
@gafter gafter added Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality and removed Concept-Code Quality Improvement labels Sep 17, 2019
@alrz alrz mentioned this issue Dec 24, 2019
Merged
@333fred
Copy link
Member

333fred commented Feb 4, 2020

We're going to keep ConversionGroup, it simplifies the walker significantly.

@333fred 333fred closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cston cston

Labels
Area-Compilers Bug Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
Compiler.Next
Development

No branches or pull requests
5 participants
@jaredpar @333fred @gafter @cston @jcouv