Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining operators via Extension Methods #5165

Closed
rftobler opened this issue Sep 11, 2015 · 7 comments
Closed

Defining operators via Extension Methods #5165

rftobler opened this issue Sep 11, 2015 · 7 comments

Comments

@rftobler
Copy link

It is easy to define multi-dimensional vectors in a generic way, with all the necessary generic operations. In order to specialize such generics for arithmetic operations, it would be great if operators where allowed to be defined via extension methods.

This would allow to replace such things

public static class VectorOfDoubleExtensions
{
    public static Vector<double> Plus(this Vector<double> a, Vector<double> b)
    { ... }
}

Vector<double> a, b;
var c = a.Plus(b);

with operators:

public static class VectorOfDoubleExtensions
{
    public static Vector<double> operator+(this Vector<double> a, Vector<double> b)
    { ... }
}

Vector<double> a, b;
var c = a + b;
@RichiCoder1
Copy link

I think this may have been mentioned before, but I can't find an issue. Either way, 👍

@dsaf
Copy link

dsaf commented Sep 11, 2015

Same idea, different sample #4945.

@aluanhaddad
Copy link

@rftobler
I like this idea a lot. It would be useful for wring DSLs and for many other things. Can you add an example of defining a generic extension operator, assuming this is part of what you are proposing, to the proposal?
e.g:

public static Func<T, bool> operator &<T>(this Func<T, bool> first, Func<T, bool> second) 
{
    return x => first(x) & second(x);
}
public static Func<T, bool> operator !<T>(this Func<T, bool> predicate) 
{
    return x => !predicate(x);
}

...
Func<int, bool> even = x => x % 2 == 0;
Func<int, bool> greaterThanTen = x => x > 10;
var odd = !even;

var evensGreaterThanTen = numbers.Where(even & greaterThanTen);

var oddsLessThanTen = numbers.Where(odd & !greaterThanTen);

@gafter
Copy link
Member

gafter commented Nov 20, 2015

See also #3357

@grwGeo
Copy link

grwGeo commented Jul 22, 2016

@aluanhaddad Trying to model some mathematical entities in the past I have come across the need to have generic operators. Although this is different to extending operators which belongs to 'Type Extensibility' (see e.g. [#3357]), I have needed something like:

public class MyGenericClass<T>
{
      public static MyGenericClass<U> operator +<T, S>(MyGenericClass<T> first, 
            MyGenericClass<S> second) 
      {
           //return 'a MyGenericClass<U> where U depends on T and S';
      }
}

Also type inference in this scenario is crucial.

@aluanhaddad
Copy link

@grwGeo I definitely think that kind of increased expressiveness would be valuable. Although, as you note, you're use case is not directly related to type extensibility, extending one of the types with a generic extension operator would indeed be an intuitive and practical way to accomplish it.

@gafter
Copy link
Member

gafter commented Aug 11, 2017

We are now taking language feature discussion in other repositories:

Features that are under active design or development, or which are "championed" by someone on the language design team, have already been moved either as issues or as checked-in design documents. For example, the proposal in this repo "Proposal: Partial interface implementation a.k.a. Traits" (issue 16139 and a few other issues that request the same thing) are now tracked by the language team at issue 52 in https:/dotnet/csharplang/issues, and there is a draft spec at https:/dotnet/csharplang/blob/master/proposals/default-interface-methods.md and further discussion at issue 288 in https:/dotnet/csharplang/issues. Prototyping of the compiler portion of language features is still tracked here; see, for example, https:/dotnet/roslyn/tree/features/DefaultInterfaceImplementation and issue 17952.

In order to facilitate that transition, we have started closing language design discussions from the roslyn repo with a note briefly explaining why. When we are aware of an existing discussion for the feature already in the new repo, we are adding a link to that. But we're not adding new issues to the new repos for existing discussions in this repo that the language design team does not currently envision taking on. Our intent is to eventually close the language design issues in the Roslyn repo and encourage discussion in one of the new repos instead.

Our intent is not to shut down discussion on language design - you can still continue discussion on the closed issues if you want - but rather we would like to encourage people to move discussion to where we are more likely to be paying attention (the new repo), or to abandon discussions that are no longer of interest to you.

If you happen to notice that one of the closed issues has a relevant issue in the new repo, and we have not added a link to the new issue, we would appreciate you providing a link from the old to the new discussion. That way people who are still interested in the discussion can start paying attention to the new issue.

Also, we'd welcome any ideas you might have on how we could better manage the transition. Comments and discussion about closing and/or moving issues should be directed to #18002. Comments and discussion about this issue can take place here or on an issue in the relevant repo.


This may be close enough to dotnet/csharplang#192, or perhaps even dotnet/csharplang#110 and dotnet/csharplang#164, that discussion can continue there.

@gafter gafter closed this as completed Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants