Escape record keywords

[SteveDunn]

See issue #74117 where it was decided that records should be escaped, even though they're not keywords, as it is the safer thing to do.

See other PR #74125

[333fred]

@dotnet/roslyn-compiler for a second review.

[cston]

SymbolKind.Alias

Are we testing the alias case? (See SymbolDisplayTests.TestAlias1 for an example of an alias test.)

[SteveDunn]

Thanks, I have added a test for an alias. If Goo the new Foo? :)

[cston]

Consider rearranging to avoid calculating isNamedTypeOrAliasName or reassigning text unnecessarily. Perhaps:

if (_escapeKeywordIdentifiers && IsEscapable(kind))
{
    text = EscapeIdentifer(text, symbol?.Kind is SymbolKind.NamedType or SymbolKind.Alias);
}

[SteveDunn]

Actually, looking at the previous line, we return if !escapeKeywordIdentifers - so we can omit that check here.

[cston]

Yes, we're checking !escapeKeywordIdentifiers earlier but the two if statements could be combined to avoid two return new SymbolDisplayPart(kind, symbol, text);.