Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UnscopedRef handling in indexers #74343

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Fix UnscopedRef handling in indexers #74343

merged 3 commits into from
Jul 23, 2024

Commits on Jul 15, 2024

  1. Fix UnscopedRef handling in indexers 

    The object initializer logic wasn't completely handling the lifetime of
the `in` part of parameters. It was considering it escaping even if it
wasn't marked as `[UnscopedRef]`

closes dotnet#66056
    @jaredpar
    jaredpar committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1b5ae65 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Rikki Gibson <[email protected]>
    @jaredpar @RikkiGibson
    jaredpar and RikkiGibson authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2dee10c View commit details
    Browse the repository at this point in the history

  2. PR feedback

    @jaredpar
    jaredpar committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    e66b86b View commit details
    Browse the repository at this point in the history