Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asserts to improve diagnosability of dartlab test failure #74391

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

RikkiGibson
Copy link
Contributor

@RikkiGibson RikkiGibson commented Jul 15, 2024

Teams thread: https://teams.microsoft.com/l/message/19:[email protected]/1720564915113?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4ba7372f-2799-4677-89f0-7a1aaea3706c&parentMessageId=1720564915113&teamName=.NET%20Developer%20Experience&channelName=InfraSwat&createdTime=1720564915113

We are trying to learn more about recent dartlab test failures:

  Failed Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpBuild.BuildWithCommandLine (VS2022) [16 s]
  Error Message:
   Assert.Equal() Failure
Expected: 0
Actual:   1
  Stack Trace:
     at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpBuild.<BuildWithCommandLine>d__2.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpBuild.cs:line 69
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
  Failed Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicEditAndContinue+CommonProjectSystem.EditLambdaExpression (VS2022) [18 s]
  Error Message:
   Assert.Empty() Failure
Collection: ["TestProj.vbproj(1, 1): warning NU1604: Project dep"...]
  Stack Trace:
     at Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicEditAndContinue.<EditLambdaExpression>d__10.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/VisualBasic/BasicEditAndContinue.cs:line 144
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
  Failed Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicEditAndContinue+CommonProjectSystem.MultiProjectDebuggingWhereNotAllModulesAreLoaded (VS2022) [11 s]
  Error Message:
   Assert.Empty() Failure
Collection: ["TestProj.vbproj(1, 1): warning NU1604: Project dep"...]
  Stack Trace:
     at Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicEditAndContinue.<MultiProjectDebuggingWhereNotAllModulesAreLoaded>d__13.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/VisualBasic/BasicEditAndContinue.cs:line 250
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

@RikkiGibson RikkiGibson requested a review from a team as a code owner July 15, 2024 16:52
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 15, 2024
@RikkiGibson RikkiGibson merged commit d9aa209 into dotnet:main Jul 15, 2024
25 checks passed
@RikkiGibson RikkiGibson deleted the expand-asserts branch July 15, 2024 19:40
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 15, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants