Set ScaleFactor for inheritance margin context menu #74849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| { | ||
| var zoomTransform = new ScaleTransform(_scaleFactor, _scaleFactor); | ||
| zoomTransform.Freeze(); | ||
| LayoutTransform = zoomTransform; |
There was a problem hiding this comment.
nit. can this be a local function? or just inline entirely in to the constructor.
| @@ -25,20 +26,31 @@ internal partial class InheritanceMarginContextMenu : ContextMenu | |||
| private readonly IUIThreadOperationExecutor _operationExecutor; | |||
| private readonly Workspace _workspace; | |||
| private readonly IAsynchronousOperationListener _listener; | |||
| private readonly double _scaleFactor; | |||
There was a problem hiding this comment.
do you need to acctually save this? it appears to only be used once.
| InitializeComponent(); | ||
| SetZoom(); |
There was a problem hiding this comment.
can this just be:
Suggested change
| SetZoom(); | |
| this.LayoutTransformation = new ScaleTransform(scaleFactor, scaleFactor).Freeze(); |
?
There was a problem hiding this comment.
The Freeze method returns void so it can't be quite this simple. An AsFrozen generic extension method would likely work.
CyrusNajmabadi
approved these changes
Aug 22, 2024
Open
3 tasks
CyrusNajmabadi
approved these changes
Aug 22, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #74035
Current behavior:
After:
