Switch to just using paths as keys for file watching #74877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Aug 23, 2024
| @@ -31,7 +31,7 @@ internal sealed class FileWatchedReferenceFactory<TReference> | |||
| /// are only created once we are actually applying a batch because we don't determine until the batch is applied if | |||
| /// the file reference will actually be a file reference or it'll be a converted project reference. | |||
| /// </summary> | |||
| private readonly Dictionary<TReference, (IWatchedFile Token, int RefCount)> _referenceFileWatchingTokens = []; | |||
| private readonly Dictionary<string, (IWatchedFile Token, int RefCount)> _referenceFileWatchingTokens = []; | |||
There was a problem hiding this comment.
this is the crux of the change. it keeps the token/ref-count assocaited with the path, not the reerence identity anymore.
There was a problem hiding this comment.
Dumb question: Could _previousDisposalLocations key on the path too?
|
@jasonmalinowski @ToddGrun @dibarbet ptal :) |
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies work happening in #74780
In that PR we want to be able to make things like AnalyzerFileReferences temporarily, but switch out with IsolatedReferences to get dedicated ALCs. If we use the analyzer ref itself as a key, this becomes much more complicated. However, if all we're using is the path anyways (for both listening to notifications, and for reporting them externally), then it's simpler to just base the API on that.