RuntimeConfigParserTasksAssemblyPath in Microsoft.NET.Runtime.RuntimeConfigParser.Task is wrong #53811
Assignees
Labels
Comments
|
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
dotnet-issue-labeler
bot
added
the
untriaged
61 tasks
|
Tagging subscribers to this area: @directhex Issue DetailsDescriptionThe $ cat Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/Sdk/Sdk.props
<Project>
<PropertyGroup>
<RuntimeConfigParserTasksAssemblyPath>$(MSBuildThisFileDirectory)..\tasks\RuntimeConfigParser.dll</RuntimeConfigParserTasksAssemblyPath>
</PropertyGroup>
<UsingTask TaskName="RuntimeConfigParserTask" AssemblyFile="$(RuntimeConfigParserTasksAssemblyPath)" />
</Project>The $ find Microsoft.NET.Runtime.RuntimeConfigParser.Task/
Microsoft.NET.Runtime.RuntimeConfigParser.Task/
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/Icon.png
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/tasks
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/tasks/net6.0
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/tasks/net6.0/RuntimeConfigParser.dll
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/tasks/net472
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/tasks/net472/RuntimeConfigParser.dll
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/Microsoft.NET.Runtime.RuntimeConfigParser.Task.nuspec
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/Sdk
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/Sdk/Sdk.props
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/THIRD-PARTY-NOTICES.TXT
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/build
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/build/Microsoft.NET.Runtime.RuntimeConfigParser.Task.props
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/LICENSE.TXT
Microsoft.NET.Runtime.RuntimeConfigParser.Task//6.0.0-preview.6.21276.13/Microsoft.NET.Runtime.RuntimeConfigParser.Task.nupkgThe assembly seems to come in two variants, so it's in two folders: CC @steveisok
|
steveisok
pushed a commit
to steveisok/runtime
that referenced
this issue
Jun 7, 2021
Fixes dotnet#53811 The props were not taking into account the right paths.
ghost
added
the
in-pr
|
I got this to work for now with: @steveisok I also had to do: <Import Sdk="Microsoft.NET.Runtime.RuntimeConfigParser.Task" Project="Sdk.props" />Should the Mono.Toolchain's |
Yes, I'll add it. |
steveisok
added a commit
that referenced
this issue
Jun 8, 2021
Fixes #53811 The props were not taking into account the right paths.
ghost
removed
the
in-pr
jonathanpeppers
added a commit
to dotnet/android
that referenced
this issue
Jun 21, 2021
Context: dotnet/runtime#53811 dotnet/runtime#53811 is now solved, so we can remove the workaround.
jonathanpeppers
added a commit
to dotnet/android
that referenced
this issue
Jun 21, 2021
Context: dotnet/runtime#53811 dotnet/runtime#53811 is now solved, so we can remove the workaround.
jonathanpeppers
added a commit
to dotnet/android
that referenced
this issue
Jun 23, 2021
Changes: dotnet/installer@abb57b4...38e12ca Changes: dotnet/linker@21df7db...c739a81 Changes: dotnet/runtime@5b8e178...24950a3 Updates: * Microsoft.Dotnet.Sdk.Internal: from 6.0.100-preview.6.21313.2 to 6.0.100-preview.7.21321.2 * Microsoft.NET.ILLink.Tasks: from 6.0.100-preview.6.21304.2 to 6.0.100-preview.6.21317.4 * Microsoft.NETCore.App.Ref: from 6.0.0-preview.6.21306.1 to 6.0.0-preview.7.21319.2 * Remove workarounds for <RuntimeConfigParserTask/> Context: dotnet/runtime#53811 dotnet/runtime#53811 is now solved, so we can remove the workaround. * Update .apkdesc files * [tests] temporarily skip asserts in BuildBasicBindingLibrary Context: dotnet/msbuild#6609 It seems that properties are missing from MSBuild logs, ignoring part of this test for now. * [templates] set .png files to `copyOnly` Context: dotnet/templating#3325 Context: https:/dotnet/templating/wiki/Reference-for-template.json#content-manipulation In the current bump, `dotnet new android` + `dotnet build` fails with: Resources\mipmap-xxxhdpi\ic_launcher_round.png error APT2000: failed reading from input: PNG chunk type 49444154 is too large: chunk length is 10836 but chunk starts at byte 45/8187. The .NET templating system has a `copyOnly` mode for files that do not need any text replaced. This is a performance feature, but it also happens to workaround this issue. We should be doing this on `.png` files *anyway*, as we don't need potential "text" to be replaced. I will probably need to make similar changes in xamarin/xamarin-macios and dotnet/maui. Co-authored-by: Jonathan Peppers <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
The
RuntimeConfigParserTasksAssemblyPathproperty in theMicrosoft.NET.Runtime.RuntimeConfigParser.TaskNuGet is wrong:The
RuntimeConfigParserTasksAssemblyPathvariable points totasks\RuntimeConfigParser.dllinside the NuGet, but the assembly is in a different folder:The assembly seems to come in two variants, so it's in two folders:
tasks/net6.0andtasks/net472.CC @steveisok
The text was updated successfully, but these errors were encountered: