New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase System.IO.FileSystem test coverage #54495

Open

2 of 8 tasks

adamsitnik opened this issue Jun 21, 2021 · 3 comments

Labels

Milestone

Member

adamsitnik commented Jun 21, 2021 •

edited

Loading

We need tests for:

reading from and writing to files located on a remote machine (Throws an exception when opening an existing file #54474 and A System.NullReferenceException was throwing when get a **gif** image using Image.FromFile() method #54475, added in [FileStream] add tests for device and UNC paths #54545)
reading from and writing to files located on a device (FileStream.ReadAsync() with isAsync: true is throwing IOException #54143, added in [FileStream] add tests for device and UNC paths #54545 and add test for opening and reading from device interface #54673)
using more file systems:
- Windows NFS server (File writes to Windows NFS share silently fail... #44546)
- delayed allocations like ext4 from What is the recommended File IO API usage pattern with regards to ext4 delayed allocations? #32600
- different max file size like FAT32 (System.IO.FileSystem tests fail all over with temp on Fat32 #66544) (test)
- probably much more than the three above
writing to a disk that becomes full (Fix: FileStream.Dispose silently fails on Dispose when disk has run out of space #38742)

adamsitnik added the area-System.IO label

adamsitnik added this to the 7.0.0 milestone

ghost commented Jun 21, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

We need tests for:

reading from and writing to files located on a remote machine (Throws an exception when opening an existing file #54474 and A System.NullReferenceException was throwing when get a **gif** image using Image.FromFile() method #54475)
using more file systems:
- Windows NFS server (File writes to Windows NFS share silently fail... #44546)
- delayed allocations like ext4 from What is the recommended File IO API usage pattern with regards to ext4 delayed allocations? #32600
- different max file size like FAT32 (test)
- probably much more than the three above
writing to a disk that becomes full (Fix: FileStream.Dispose silently fails on Dispose when disk has run out of space #38742)

Author:	adamsitnik
Assignees:	-
Labels:	`area-System.IO`
Milestone:	7.0.0

dotnet-issue-labeler bot added the untriaged label

Member Author

adamsitnik commented Jun 21, 2021

@jozkee @stephentoub @carlossanlop PTAL at the list and feel free to add something. I would really love to extend our test coverage in .NET 7.

adamsitnik removed the untriaged label

adamsitnik mentioned this issue

[FileStream] handle UNC and device paths #54483

Merged

Member

carlossanlop commented Jun 21, 2021

Writing to a remote disk that becomes full (we currently have a manual test, not sure if this could be automated).
Explicitly get results for different filesystems: NTFS, FAT32, EXT4, APFS, etc.

adamsitnik mentioned this issue

[FileStream] add tests for device and UNC paths #54545

Merged

adamsitnik mentioned this issue

RandomAccess.Write methods should perform full writes #55473

Closed

adamsitnik mentioned this issue

[release/6.0] for non-seekable file handles, the OVERLAPPED offset must be set to 0 #60931

Closed

adamsitnik mentioned this issue

System.IO.FileSystem tests fail all over with temp on Fat32 #66544

Open

jeffhandley modified the milestones: 7.0.0, Future

adamsitnik mentioned this issue

[release/7.0] Implement proper File System detection for Apple OSes #74560

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment