Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Failures in System.Linq.Expressions.Tests.CompilerTests test suite #55065

Closed
MaximLipnin opened this issue Jul 2, 2021 · 3 comments
Closed

[iOS] Failures in System.Linq.Expressions.Tests.CompilerTests test suite #55065

MaximLipnin opened this issue Jul 2, 2021 · 3 comments
Labels
area-System.Linq.Expressions untriaged New issue has not been triaged by the area owner

Comments

@MaximLipnin
Copy link
Contributor

When trying to enable the interpretation mode for LambdaCompiler on iOS-like targets in #54970, I get the test failures in System.Linq.Expressions.Tests.CompilerTests test suite like below:

    <collection total="8" passed="2" failed="6" skipped="0" name="Test collection for System.Linq.Expressions.Tests.CompilerTests" time="0.006">
      <test name="System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_ShareReferences" type="System.Linq.Expressions.Tests.CompilerTests" method="EmitConstantsToIL_ShareReferences" time="0.0014656" result="Fail">
        <failure exception-type="System.TypeLoadException">
          <message><![CDATA[System.TypeLoadException : Could not resolve type with token 01000085 from typeref (expected class 'System.Runtime.CompilerServices.Closure' in assembly 'System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a')]]></message>
          <stack-trace><![CDATA[   at System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_ShareReferences()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]></stack-trace>
        </failure>
      </test>
      <test name="System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_ReferenceTypes" type="System.Linq.Expressions.Tests.CompilerTests" method="EmitConstantsToIL_ReferenceTypes" time="0.0001519" result="Fail">
        <failure exception-type="System.TypeLoadException">
          <message><![CDATA[System.TypeLoadException : Could not resolve type with token 01000085 from typeref (expected class 'System.Runtime.CompilerServices.Closure' in assembly 'System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a')]]></message>
          <stack-trace><![CDATA[   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[String](String value, Int32 expectedCount)
   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[String](String value)
   at System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_ReferenceTypes()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]></stack-trace>
        </failure>
      </test>
      <test name="System.Linq.Expressions.Tests.CompilerTests.VariableBinder_CatchBlock_Filter2" type="System.Linq.Expressions.Tests.CompilerTests" method="VariableBinder_CatchBlock_Filter2" time="0.002529" result="Pass" />
      <test name="System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_NonNullableValueTypes" type="System.Linq.Expressions.Tests.CompilerTests" method="EmitConstantsToIL_NonNullableValueTypes" time="0.000228" result="Fail">
        <failure exception-type="System.TypeLoadException">
          <message><![CDATA[System.TypeLoadException : Could not resolve type with token 01000085 from typeref (expected class 'System.Runtime.CompilerServices.Closure' in assembly 'System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a')]]></message>
          <stack-trace><![CDATA[   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[Boolean](Boolean value, Int32 expectedCount)
   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[Boolean](Boolean value)
   at System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_NonNullableValueTypes()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]></stack-trace>
        </failure>
      </test>
      <test name="System.Linq.Expressions.Tests.CompilerTests.VariableBinder_CatchBlock_Filter1" type="System.Linq.Expressions.Tests.CompilerTests" method="VariableBinder_CatchBlock_Filter1" time="0.0002116" result="Pass" />
      <test name="System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_NullableValueTypes" type="System.Linq.Expressions.Tests.CompilerTests" method="EmitConstantsToIL_NullableValueTypes" time="0.0005196" result="Fail">
        <failure exception-type="System.TypeLoadException">
          <message><![CDATA[System.TypeLoadException : Could not resolve type with token 01000085 from typeref (expected class 'System.Runtime.CompilerServices.Closure' in assembly 'System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a')]]></message>
          <stack-trace><![CDATA[   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[Nullable`1](Nullable`1 value, Int32 expectedCount)
   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[Nullable`1](Nullable`1 value)
   at System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_NullableValueTypes()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]></stack-trace>
        </failure>
      </test>
      <test name="System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_LiftedToClosure" type="System.Linq.Expressions.Tests.CompilerTests" method="EmitConstantsToIL_LiftedToClosure" time="0.0001895" result="Fail">
        <failure exception-type="System.TypeLoadException">
          <message><![CDATA[System.TypeLoadException : Could not resolve type with token 01000085 from typeref (expected class 'System.Runtime.CompilerServices.Closure' in assembly 'System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a')]]></message>
          <stack-trace><![CDATA[   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[DateTime](DateTime value, Int32 expectedCount)
   at System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_LiftedToClosure()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]></stack-trace>
        </failure>
      </test>
      <test name="System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_Enums" type="System.Linq.Expressions.Tests.CompilerTests" method="EmitConstantsToIL_Enums" time="0.0002065" result="Fail">
        <failure exception-type="System.TypeLoadException">
          <message><![CDATA[System.TypeLoadException : Could not resolve type with token 01000085 from typeref (expected class 'System.Runtime.CompilerServices.Closure' in assembly 'System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a')]]></message>
          <stack-trace><![CDATA[   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[ConstantsEnum](ConstantsEnum value, Int32 expectedCount)
   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[ConstantsEnum](ConstantsEnum value)
   at System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_Enums()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]></stack-trace>
        </failure>
      </test>
    </collection>

https:/dotnet/runtime/pull/54970/checks?check_run_id=2961997278

cc @steveisok
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Linq.Expressions untriaged New issue has not been triaged by the area owner labels Jul 2, 2021
@ghost
Copy link

ghost commented Jul 2, 2021

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

Issue Details

When trying to enable the interpretation mode for LambdaCompiler on iOS-like targets in #54970, I get the test failures in System.Linq.Expressions.Tests.CompilerTests test suite like below:

    <collection total="8" passed="2" failed="6" skipped="0" name="Test collection for System.Linq.Expressions.Tests.CompilerTests" time="0.006">
      <test name="System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_ShareReferences" type="System.Linq.Expressions.Tests.CompilerTests" method="EmitConstantsToIL_ShareReferences" time="0.0014656" result="Fail">
        <failure exception-type="System.TypeLoadException">
          <message><![CDATA[System.TypeLoadException : Could not resolve type with token 01000085 from typeref (expected class 'System.Runtime.CompilerServices.Closure' in assembly 'System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a')]]></message>
          <stack-trace><![CDATA[   at System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_ShareReferences()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]></stack-trace>
        </failure>
      </test>
      <test name="System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_ReferenceTypes" type="System.Linq.Expressions.Tests.CompilerTests" method="EmitConstantsToIL_ReferenceTypes" time="0.0001519" result="Fail">
        <failure exception-type="System.TypeLoadException">
          <message><![CDATA[System.TypeLoadException : Could not resolve type with token 01000085 from typeref (expected class 'System.Runtime.CompilerServices.Closure' in assembly 'System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a')]]></message>
          <stack-trace><![CDATA[   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[String](String value, Int32 expectedCount)
   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[String](String value)
   at System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_ReferenceTypes()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]></stack-trace>
        </failure>
      </test>
      <test name="System.Linq.Expressions.Tests.CompilerTests.VariableBinder_CatchBlock_Filter2" type="System.Linq.Expressions.Tests.CompilerTests" method="VariableBinder_CatchBlock_Filter2" time="0.002529" result="Pass" />
      <test name="System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_NonNullableValueTypes" type="System.Linq.Expressions.Tests.CompilerTests" method="EmitConstantsToIL_NonNullableValueTypes" time="0.000228" result="Fail">
        <failure exception-type="System.TypeLoadException">
          <message><![CDATA[System.TypeLoadException : Could not resolve type with token 01000085 from typeref (expected class 'System.Runtime.CompilerServices.Closure' in assembly 'System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a')]]></message>
          <stack-trace><![CDATA[   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[Boolean](Boolean value, Int32 expectedCount)
   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[Boolean](Boolean value)
   at System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_NonNullableValueTypes()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]></stack-trace>
        </failure>
      </test>
      <test name="System.Linq.Expressions.Tests.CompilerTests.VariableBinder_CatchBlock_Filter1" type="System.Linq.Expressions.Tests.CompilerTests" method="VariableBinder_CatchBlock_Filter1" time="0.0002116" result="Pass" />
      <test name="System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_NullableValueTypes" type="System.Linq.Expressions.Tests.CompilerTests" method="EmitConstantsToIL_NullableValueTypes" time="0.0005196" result="Fail">
        <failure exception-type="System.TypeLoadException">
          <message><![CDATA[System.TypeLoadException : Could not resolve type with token 01000085 from typeref (expected class 'System.Runtime.CompilerServices.Closure' in assembly 'System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a')]]></message>
          <stack-trace><![CDATA[   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[Nullable`1](Nullable`1 value, Int32 expectedCount)
   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[Nullable`1](Nullable`1 value)
   at System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_NullableValueTypes()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]></stack-trace>
        </failure>
      </test>
      <test name="System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_LiftedToClosure" type="System.Linq.Expressions.Tests.CompilerTests" method="EmitConstantsToIL_LiftedToClosure" time="0.0001895" result="Fail">
        <failure exception-type="System.TypeLoadException">
          <message><![CDATA[System.TypeLoadException : Could not resolve type with token 01000085 from typeref (expected class 'System.Runtime.CompilerServices.Closure' in assembly 'System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a')]]></message>
          <stack-trace><![CDATA[   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[DateTime](DateTime value, Int32 expectedCount)
   at System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_LiftedToClosure()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]></stack-trace>
        </failure>
      </test>
      <test name="System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_Enums" type="System.Linq.Expressions.Tests.CompilerTests" method="EmitConstantsToIL_Enums" time="0.0002065" result="Fail">
        <failure exception-type="System.TypeLoadException">
          <message><![CDATA[System.TypeLoadException : Could not resolve type with token 01000085 from typeref (expected class 'System.Runtime.CompilerServices.Closure' in assembly 'System.Linq.Expressions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a')]]></message>
          <stack-trace><![CDATA[   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[ConstantsEnum](ConstantsEnum value, Int32 expectedCount)
   at System.Linq.Expressions.Tests.CompilerTests.VerifyEmitConstantsToIL[ConstantsEnum](ConstantsEnum value)
   at System.Linq.Expressions.Tests.CompilerTests.EmitConstantsToIL_Enums()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]></stack-trace>
        </failure>
      </test>
    </collection>

https:/dotnet/runtime/pull/54970/checks?check_run_id=2961997278

cc @steveisok

Author: MaximLipnin
Assignees: -
Labels:

area-System.Linq.Expressions, untriaged
Milestone: -

@MaximLipnin
Copy link
Contributor Author

Perhaps, it may be addressed by setting the right condition for IsInterpreting property in the test csproj file.

@MaximLipnin
Copy link
Contributor Author

Setting <IsInterpreting Condition="'$(TargetsiOS)' == 'true' or '$(TargetstvOS)' == 'true' or '$(TargetsMacCatalyst)' == 'true'">true</IsInterpreting> in the test project file did the trick, closing it.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Linq.Expressions untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MaximLipnin