Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Move the default property settings that were used to build the runtime pack, to wasm-props.json included in the runtime pack #91628

Closed
radical opened this issue Sep 5, 2023 · 2 comments · Fixed by #103422
Closed

[wasm] Move the default property settings that were used to build the runtime pack, to wasm-props.json included in the runtime pack #91628

radical opened this issue Sep 5, 2023 · 2 comments · Fixed by #103422
Assignees
@ilonatommy
Labels
arch-wasm WebAssembly architecture area-Build-mono in-pr There is an active PR which will close this issue when it is merged
Milestone
9.0.0

Comments

@radical
Copy link
Member

radical commented Sep 5, 2023

This should replace the hardcoded table in WasmApp.Native.targets - _BoolPropertiesThatTriggerRelinking.

cc @pavelsavara
@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Sep 5, 2023
@radical radical self-assigned this Sep 5, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 5, 2023
@ghost
Copy link

ghost commented Sep 5, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This should replace the hardcoded table in WasmApp.Native.targets - _BoolPropertiesThatTriggerRelinking.

cc @pavelsavara

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Build-mono
Milestone: -

@pavelsavara
Copy link
Member

We already have _EmccPropsJson doing similar transport

@radical radical changed the title [wasm] Move the default property settings that were used to build the runtime pack, to a file included in the runtime pack [wasm] Move the default property settings that were used to build the runtime pack, to a emcc-props.json included in the runtime pack Sep 5, 2023
@radical radical changed the title [wasm] Move the default property settings that were used to build the runtime pack, to a emcc-props.json included in the runtime pack [wasm] Move the default property settings that were used to build the runtime pack, to emcc-props.json included in the runtime pack Sep 5, 2023
@pavelsavara pavelsavara added this to the 9.0.0 milestone Sep 5, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Sep 5, 2023
@ilonatommy ilonatommy assigned ilonatommy and unassigned radical May 31, 2024
@ilonatommy ilonatommy changed the title [wasm] Move the default property settings that were used to build the runtime pack, to emcc-props.json included in the runtime pack [wasm] Move the default property settings that were used to build the runtime pack, to wasm-props.json included in the runtime pack Jun 13, 2024
@ilonatommy ilonatommy mentioned this issue Jun 13, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jun 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Build-mono in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
9.0.0
3 participants
@radical @pavelsavara @ilonatommy