Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PGO] assert "Mismatch in align instruction." #95755

Closed
EgorBo opened this issue Dec 7, 2023 · 4 comments
Closed

[PGO] assert "Mismatch in align instruction." #95755

EgorBo opened this issue Dec 7, 2023 · 4 comments
Assignees
@kunalspathak
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Milestone
9.0.0

Comments

@EgorBo
Copy link
Member

EgorBo commented Dec 7, 2023 •
edited
Loading

PGO Libraries pipelines fail with:

Mismatch in align instruction.
Containing IG: IG29
loopHeadPredIG: IG52
loopHeadIG: IG53
igInLoop: IG58
igInLoop->backEdge: IG57
igInLoop has align instruction for : IG61
Loop:
	IG53
	IG54
	IG55
	IG56
	IG57
	IG58
	IG59
	IG60
	IG61
	IG62
	IG63
	IG64
	IG65
	IG66
	IG67
	IG68
	IG69
	IG70
	IG71
	IG72
	IG73
	IG74
	IG75
	IG76
	IG77
	IG78
	IG79
	IG80
	IG81
	IG82
	IG83
	IG84
	IG85
	IG86
	IG87
	IG88
	IG89
	IG90
	IG91

Assert failure(PID 5048 [0x000013b8], Thread: 7396 [0x1ce4]): Assertion failed 'false' in 'Microsoft.CodeAnalysis.TopologicalSort:TryIterativeSort[System.__Canon](System.Collections.Generic.IEnumerable`1[System.__Canon],Microsoft.CodeAnalysis.TopologicalSortAddSuccessors`1[System.__Canon],byref):ubyte' during 'Generate code' (IL size 278; hash 0x33b57c85; Tier1-OSR)

    File: D:\a\_work\1\s\src\coreclr\jit\emit.cpp Line: 5900
    Image: C:\h\w\A83D0943\p\dotnet.exe

    Microsoft.Gen.OptionsValidation.Unit.Test.EmitterTests.InternalsVisibleToAssembliesTest(languageVersion: CSharp10) [FAIL]
      Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Exit code was -1073740286 but it should have been 42
      Stack Trace:
        /_/src/Microsoft.DotNet.RemoteExecutor/src/RemoteInvokeHandle.cs(242,0): at Microsoft.DotNet.RemoteExecutor.RemoteInvokeHandle.Dispose(Boolean disposing)
        /_/src/Microsoft.DotNet.RemoteExecutor/src/RemoteInvokeHandle.cs(55,0): at Microsoft.DotNet.RemoteExecutor.RemoteInvokeHandle.Dispose()
        /_/src/libraries/Microsoft.Extensions.Options/tests/SourceGeneration.Unit.Tests/Main.cs(1217,0): at Microsoft.Gen.OptionsValidation.Unit.Test.EmitterTests.InternalsVisibleToAssembliesTest(LanguageVersion languageVersion)
        --- End of stack trace from previous location ---
  Finished:    Microsoft.Extensions.Options.SourceGeneration.Unit.Tests

E.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=491980&view=ms.vss-test-web.build-test-results-tab&runId=11398310&resultId=190916&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

cc @dotnet/jit-contrib
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 7, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 7, 2023
@ghost
Copy link

ghost commented Dec 7, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

PGO Libraries pipeline fail with:

Mismatch in align instruction.
Containing IG: IG29
loopHeadPredIG: IG52
loopHeadIG: IG53
igInLoop: IG58
igInLoop->backEdge: IG57
igInLoop has align instruction for : IG61
Loop:
	IG53
	IG54
	IG55
	IG56
	IG57
	IG58
	IG59
	IG60
	IG61
	IG62
	IG63
	IG64
	IG65
	IG66
	IG67
	IG68
	IG69
	IG70
	IG71
	IG72
	IG73
	IG74
	IG75
	IG76
	IG77
	IG78
	IG79
	IG80
	IG81
	IG82
	IG83
	IG84
	IG85
	IG86
	IG87
	IG88
	IG89
	IG90
	IG91

Assert failure(PID 5048 [0x000013b8], Thread: 7396 [0x1ce4]): Assertion failed 'false' in 'Microsoft.CodeAnalysis.TopologicalSort:TryIterativeSort[System.__Canon](System.Collections.Generic.IEnumerable`1[System.__Canon],Microsoft.CodeAnalysis.TopologicalSortAddSuccessors`1[System.__Canon],byref):ubyte' during 'Generate code' (IL size 278; hash 0x33b57c85; Tier1-OSR)

    File: D:\a\_work\1\s\src\coreclr\jit\emit.cpp Line: 5900
    Image: C:\h\w\A83D0943\p\dotnet.exe

    Microsoft.Gen.OptionsValidation.Unit.Test.EmitterTests.InternalsVisibleToAssembliesTest(languageVersion: CSharp10) [FAIL]
      Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Exit code was -1073740286 but it should have been 42
      Stack Trace:
        /_/src/Microsoft.DotNet.RemoteExecutor/src/RemoteInvokeHandle.cs(242,0): at Microsoft.DotNet.RemoteExecutor.RemoteInvokeHandle.Dispose(Boolean disposing)
        /_/src/Microsoft.DotNet.RemoteExecutor/src/RemoteInvokeHandle.cs(55,0): at Microsoft.DotNet.RemoteExecutor.RemoteInvokeHandle.Dispose()
        /_/src/libraries/Microsoft.Extensions.Options/tests/SourceGeneration.Unit.Tests/Main.cs(1217,0): at Microsoft.Gen.OptionsValidation.Unit.Test.EmitterTests.InternalsVisibleToAssembliesTest(LanguageVersion languageVersion)
        --- End of stack trace from previous location ---
  Finished:    Microsoft.Extensions.Options.SourceGeneration.Unit.Tests

E.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=491980&view=ms.vss-test-web.build-test-results-tab&runId=11398310&resultId=190916&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

cc @dotnet/jit-contrib

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@EgorBo EgorBo added the blocking-clean-ci-optional Blocking optional rolling runs label Dec 7, 2023
@EgorBo EgorBo added this to the 9.0.0 milestone Dec 7, 2023
@EgorBo EgorBo removed the untriaged New issue has not been triaged by the area owner label Dec 7, 2023
@kunalspathak kunalspathak mentioned this issue Dec 8, 2023
Merged
@kunalspathak kunalspathak self-assigned this Dec 8, 2023
@kunalspathak
Copy link
Member

I will look into this if it repro after #95836 is merged.

@amanasifkhalid
Copy link
Member

This pipeline is still red, but I haven't seen this assert pop up in the last few runs, and #95836 has been merged in. Should we close this issue?

@kunalspathak
Copy link
Member

This pipeline is still red, but I haven't seen this assert pop up in the last few runs, and #95836 has been merged in. Should we close this issue?

Yep.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
3 participants
@EgorBo @kunalspathak @amanasifkhalid