Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to load CustomModifiers for runtime field hits an assert #97116

Closed
buyaa-n opened this issue Jan 17, 2024 · 2 comments
Closed

Trying to load CustomModifiers for runtime field hits an assert #97116

buyaa-n opened this issue Jan 17, 2024 · 2 comments

Comments

@buyaa-n
Copy link
Member

buyaa-n commented Jan 17, 2024

Regex.CompileToAssembly test is failing when the ModulBuilder tries to load custom modifiers for a field:

public override Type[] GetRequiredCustomModifiers()
{
return GetSignature().GetCustomModifiers(1, true);
}

This call eventually hit assert in:

_ASSERTE(parameterIndex == 0);

This doesn't happen locally (64 bit Windows), hits the Assert in some Linux legs and 32 bit windows leg on CI, looks like a bug to me.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 17, 2024
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 17, 2024
@ghost
Copy link

ghost commented Jan 18, 2024

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

Issue Details

Regex.CompileToAssembly test is failing when the ModulBuilder tries to load custom modifiers for a field:

public override Type[] GetRequiredCustomModifiers()
{
return GetSignature().GetCustomModifiers(1, true);
}

This call eventually hit assert in:

_ASSERTE(parameterIndex == 0);

This doesn't happen locally (64 bit Windows), hits the Assert in some Linux legs and 32 bit windows leg on CI, looks like a bug to me.

Author: buyaa-n
Assignees: -
Labels:

area-System.Reflection.Emit, untriaged, needs-area-label

Milestone: -

@jkotas jkotas removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 18, 2024
@buyaa-n buyaa-n added this to the 9.0.0 milestone Jan 18, 2024
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jan 18, 2024
@buyaa-n
Copy link
Member Author

buyaa-n commented Jul 26, 2024

This was fixed with the PR #96805

@buyaa-n buyaa-n closed this as completed Jul 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants