Update emsdk dependency to match what emsdk produces #105434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
lewing
approved these changes
Jul 24, 2024
|
actually it looks there is a reference to this package in part of the tooling, let me see if I can clean that up |
|
@lewing I also needed to clean up the version props, if you aren't getting to that too |
carlossanlop
approved these changes
Jul 24, 2024
lewing
reviewed
Jul 24, 2024
lewing
reviewed
Jul 24, 2024
lewing
reviewed
Jul 24, 2024
| @@ -108,7 +108,7 @@ | |||
| Only wasi doesn't come with its own python and windows uses 32-bit python, so refer to the transport pack instead. | |||
| --> | |||
| <PropertyGroup Condition="'$(HostOS)' == 'windows' and '$(TargetsWasi)' == 'true'"> | |||
| <PythonCmd>$([MSBuild]::NormalizePath('$(PkgMicrosoft_NET_Runtime_Emscripten_3_1_34_Python_win-x64)', 'tools', 'python'))</PythonCmd> | |||
| <PythonCmd>$([MSBuild]::NormalizePath('$(PkgMicrosoft_NET_Runtime_Emscripten_3_1_56_Python_win-x64)', 'tools', 'python'))</PythonCmd> | |||
There was a problem hiding this comment.
I don't see an obvious way to keep the version string out of this one, the plan is to move this logic to emsdk properly where it is easier to do
cc @radekdoulik
lewing
added
area-Build-mono
and removed
needs-area-label
|
/ba-g analysis is green but preview branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.