-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NativeAOT Thread Name #107943
Merged
Merged
NativeAOT Thread Name #107943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hez2010
reviewed
Sep 18, 2024
jkotas
reviewed
Sep 25, 2024
jkotas
reviewed
Sep 25, 2024
cshung
force-pushed
the
public/set-thread-name
branch
3 times, most recently
from
September 27, 2024 19:01
9e3dd91
to
746f9d0
Compare
jkotas
reviewed
Sep 27, 2024
jkotas
reviewed
Sep 27, 2024
jkotas
reviewed
Sep 27, 2024
3 tasks
cshung
force-pushed
the
public/set-thread-name
branch
from
September 28, 2024 23:44
484beff
to
1bbdef4
Compare
jkotas
reviewed
Sep 29, 2024
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.cs
Outdated
Show resolved
Hide resolved
src/mono/System.Private.CoreLib/src/System/Threading/Thread.Mono.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/RuntimeImports.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 29, 2024
src/libraries/System.Private.CoreLib/src/System/Threading/Thread.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 29, 2024
src/mono/System.Private.CoreLib/src/System/Threading/Thread.Mono.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 29, 2024
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 29, 2024
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.cs
Outdated
Show resolved
Hide resolved
This was referenced Sep 29, 2024
Open
jkotas
reviewed
Sep 29, 2024
jkotas
reviewed
Sep 29, 2024
jkotas
reviewed
Sep 29, 2024
3 tasks
am11
reviewed
Sep 29, 2024
@@ -1512,6 +1528,10 @@ namespace | |||
ThreadStubArguments* args = static_cast<ThreadStubArguments*>(argument); | |||
assert(args != nullptr); | |||
|
|||
#ifdef __APPLE__ | |||
SetThreadName(GetCurrentThread(), args->name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cshung
force-pushed
the
public/set-thread-name
branch
from
September 29, 2024 12:58
790b9d9
to
1b85298
Compare
jkotas
reviewed
Sep 29, 2024
jkotas
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
3 tasks
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
Co-authored-by: Jan Kotas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.