Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow rid from yml to sendtohelix #37652

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Flow rid from yml to sendtohelix #37652

merged 1 commit into from
Sep 30, 2020

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jun 9, 2020 •
edited
Loading

Not ideal implementation of being able to access the RID in a yml build job. Opened #37650 to replace the "Platform" format with the RID.

@ViktorHofer ViktorHofer requested a review from safern June 9, 2020 15:36
@ghost
Copy link

ghost commented Jun 9, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ViktorHofer ViktorHofer mentioned this pull request Jun 9, 2020
Merged
@safern
Copy link
Member

safern commented Jun 9, 2020

This should not be necessary. The rid should be available as we set it as PackageRID on Directory.Build.props based on osgroup and arch. Send to helix already knows this information.

Also: #37476 is outdated and haven’t merged with master where the mono jobs are collapsed.

I’ll work with @premun and @directhex to accordingly get the latest changes from master.

@safern
Copy link
Member

safern commented Jun 9, 2020

What I’m trying to say is that build-job no longer needs to publish this as we will build tests and publish to helix as part of the same job.

@ViktorHofer
Copy link
Member Author

Understood, that makes sense. Thanks

@ViktorHofer ViktorHofer closed this Jun 9, 2020
@ViktorHofer ViktorHofer deleted the TargetRidYml branch June 9, 2020 16:31
@ViktorHofer ViktorHofer restored the TargetRidYml branch September 30, 2020 09:36
@ViktorHofer ViktorHofer reopened this Sep 30, 2020
@ViktorHofer
Copy link
Member Author

Reopening as we need to flow the rid to sendtohelix.proj for #39923.

@ViktorHofer ViktorHofer removed the request for review from safern September 30, 2020 10:08
@ViktorHofer ViktorHofer changed the title Flow rid in yml jobs Flow rid from yml to sendtohelix Sep 30, 2020
@ViktorHofer
Copy link
Member Author

Failure is #42893

@ViktorHofer
Copy link
Member Author

All tests are successfully submitted to helix. Merging.

@ViktorHofer ViktorHofer merged commit f98038a into dotnet:master Sep 30, 2020
@ViktorHofer ViktorHofer deleted the TargetRidYml branch September 30, 2020 12:21
@runfoapp runfoapp bot mentioned this pull request Sep 30, 2020
Open
safern
safern reviewed Sep 30, 2020
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern left review comments

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ViktorHofer @safern @akoeplinger @Dotnet-GitSync-Bot