[mbr] [wasm] Don't automatically turn off inlining #47246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
|
Tagging subscribers to this area: @CoffeeFlux Issue DetailsInstead of turning off inlining whenever ENABLE_METADATA_UPDATE is defined in Update the browser MBR sample to use the env var
|
Instead of turning off inlining whenever ENABLE_METADATA_UPDATE is defined in the code, only turn it off when MONO_METADATA_UPDATE is set in the environment. Update the browser MBR sample to use the env var
lambdageek
force-pushed
the
mbr-wasm-inline-env-var
branch
from
60f33fe
to
672c107
Compare
CoffeeFlux
approved these changes
Jan 20, 2021
I wasn't going to measure this one - not turning off inlining unless we need was a TODO regardless. It's only going to improve the wasm perf - jit and desktop interp need additional investigation. |
vargaz
approved these changes
Jan 21, 2021
vargaz
reviewed
Jan 21, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of turning off inlining whenever ENABLE_METADATA_UPDATE is defined in
the code, only turn it off when MONO_METADATA_UPDATE is set in the environment.
Update the browser MBR sample to use the env var