Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BigInteger hex string parsing bug #54262

Merged
merged 1 commit into from
Jun 26, 2021
Merged

Conversation

jfd16
Copy link
Contributor

@jfd16 jfd16 commented Jun 16, 2021

Fixes issue #54251. The regression was introduced by PR #47842.

@ghost
Copy link

ghost commented Jun 16, 2021

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes issue #54251. The regression was introduced by PR #47842.

Author: jfd16
Assignees: -
Labels:

area-System.Numerics

Milestone: -

@danmoseley
Copy link
Member

Aside if your description included Fixes #54251 it would auto close the issue on merge. https://stackoverflow.com/a/60027286

@tannergooding
Copy link
Member

CI is currently on the floor. This will need to wait for that to come back online and tests to pass for it to be merged, but this LGTM.

CC. @pgovind for secondary review.

@stephentoub stephentoub merged commit aca3754 into dotnet:main Jun 26, 2021
@jfd16 jfd16 deleted the fix-54251 branch June 27, 2021 03:40
@ghost ghost locked as resolved and limited conversation to collaborators Jul 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants