Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Fixing debugger tests errors #54664

Merged
merged 3 commits into from
Jun 24, 2021

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Jun 24, 2021

  1. Errno is not being assigned anymore in a case like this:
    intmax_t val = strtoimax ("error", &endptr, 10);
    This was causing failures in these tests: DebuggerTests.SetVariableValueTests

  2. Passing icordbg flag as false.

Errno is not being assigned anymore.

DebuggerTests.SetVariableValueTests
@ghost
Copy link

ghost commented Jun 24, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Errno is not being assigned anymore.

DebuggerTests.SetVariableValueTests

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@thaystg thaystg added the arch-wasm WebAssembly architecture label Jun 24, 2021
@ghost
Copy link

ghost commented Jun 24, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Errno is not being assigned anymore in a case like this:

intmax_t val = strtoimax ("error", &endptr, 10);

This was causing failures in this tests: DebuggerTests.SetVariableValueTests

Author: thaystg
Assignees: -
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@thaystg thaystg requested review from lewing and radical and removed request for vargaz, lambdageek, CoffeeFlux, SamMonoRT and imhameed June 24, 2021 05:01
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pass a char *variableValueEnd argument to write_value_to_buffer and also compare endptr != variableValueEnd to make sure that there are no unconsumed digits at the end of the string?

Are these values coming from something we control, or from user JS?

@thaystg
Copy link
Member Author

thaystg commented Jun 24, 2021

It's coming from user JS.
On debugger the user can set a variable value while inspecting variables. So I would receive the new value that the user wrote to the variable as this parameter.

@thaystg
Copy link
Member Author

thaystg commented Jun 24, 2021

I will add a test trying to pass a value like "123thays" it would process until the third character of the string. I will check if in this case errno is set.

@thaystg
Copy link
Member Author

thaystg commented Jun 24, 2021

@lambdageek thanks for the hint! :)

@thaystg thaystg merged commit c6a7e2f into dotnet:main Jun 24, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants