Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiagnosticsHandler CI testing #55182

Closed
wants to merge 52 commits into from
Closed

Commits on Jul 5, 2021

  1. Configuration menu
    Copy the full SHA
    fd6765c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb64665 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ac8a81e View commit details
    Browse the repository at this point in the history
  4. Simplify enabled check

    MihaZupan committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    7ad4147 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    260e8dc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a0debd6 View commit details
    Browse the repository at this point in the history
  7. Test

    MihaZupan committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    163953a View commit details
    Browse the repository at this point in the history
  8. Add FreeBSD terminfo location (dotnet#55152)

    `ncurses` port under FreeBSD no longer uses a hashed database but instead uses the more common "directory tree" style. 
    This fixes like 1 failing runtime test for `System.Console`
    Thefrank authored Jul 5, 2021
    Configuration menu
    Copy the full SHA
    7edc27c View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. Handle FileOptions.DeleteOnClose on Unix in SafeFileHandle.Dispose (d…

    …otnet#55153)
    
    * Handle FileOptions.DeleteOnClose on Unix in SafeFileHandle.Dispose
    
    * Move file path into SafeFileHandle on Windows as well
    
    Doing so enables cleaning up a bunch of passing around of the file path, while also enabling the path to be fed to more error paths.
    
    * Update Net5Compat impl as well
    stephentoub authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    56b250b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e43f8c View commit details
    Browse the repository at this point in the history
  3. Test

    MihaZupan committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    0b8c8bb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d25af09 View commit details
    Browse the repository at this point in the history
  5. Revive dotnet#48505 (dotnet#54914)

    * Revive dotnet#48505
    
    Revive dotnet#48505 and try to find out why the change caused official builds to break.
    
    * Use OutputRid when creating .nupkgs, instead of PackageRID
    
    Co-authored-by: Adeel Mujahid <[email protected]>
    ViktorHofer and am11 authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    566b53a View commit details
    Browse the repository at this point in the history
  6. port system.diagnostics.performanceCounter (dotnet#55134)

    * port system.diagnostics.performanceCounter
    
    * remvoing custom and private targets hook and remove unused package rferences
    Anipik authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    8e3d6cd View commit details
    Browse the repository at this point in the history
  7. Add test global install path is used when DOTNET_ROOT does not exist (d…

    …otnet#54883)
    
    * Add test
    
    * PR feedback
    Add test covering case where DOTNET_ROOT exists but does not have a dotnet installation on it
    
    * Update tests
    
    * Use product behavior for test where DOTNET_ROOT exists but has no host
    
    * Fix test
    
    * Get platform specific extension for hostfxr
    Use HaveUsedNetRootInstallLocation
    mateoatr authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    1c57282 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    dd63190 View commit details
    Browse the repository at this point in the history
  9. [Mono] Optimize mono_dl_build_path for component and Android module l…

    …oading. (dotnet#54971)
    
    * Optimize mono_dl_build_path for component and Android module loading.
    
    mono_dl_build_path probes a lot of variations of paths and in some
    situations where modules uses platform specific naming,
    it could try at least two paths before getting to the correct one.
    This have been a problem for Android a long time since IO is slow
    on devices, so always failing two probes per module load adds to
    the startup time on Android.
    
    For dynamic component loading the existing schema is particular
    bad since the scenario of disabling a component means that the component
    won't exist, and using the existing probing it could do 3 or more
    load attempts before realize that the component is not present and
    use the stub implmenentation.
    
    Commit splits current mono_dl_build_path probing logic so it can be
    customized.
    
    For components a new function has been added that will
    always use platform prefix and platform suffixes, and if not found
    it will stop looking. For most platform that means only one attempt
    to load a component instead of at least 3, optimize both the scenario
    when the component is awailable as well as when it should be disabled.
    
    Commit also change the default behavior of mono_dl_build_path on Android
    reversing current schema making it more likely to find modules using
    platform specific naming, like libMyLibrary.so, in first attempt.
    It will still fallback using no prefix and default suffix and then
    the verbatim name to make sure dllimports will still work as before, but
    favorizing modules using platform specific naming.
    
    On all other platforms mono_dl_build_path will continue to keep
    its current behaviour.
    lateralusX authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    c865a54 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    86b7f92 View commit details
    Browse the repository at this point in the history
  11. Replace Composition* pkgprojs with NuGet Pack task (dotnet#55208)

    System.Composition is a meta-package only so that required a bit try and
    error but that worked out quite well. The added dependency groups in
    that meta-package are intentional.
    
    Contributes to dotnet#53202
    ViktorHofer authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    515f7c1 View commit details
    Browse the repository at this point in the history
  12. Test

    MihaZupan committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    1b752f0 View commit details
    Browse the repository at this point in the history
  13. Test

    MihaZupan committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    4a25d0a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0265e79 View commit details
    Browse the repository at this point in the history
  15. Fix inconsistent linkage error in dynamic component build on Windows. (

    …dotnet#55142)
    
    dotnet#54887 added MONO_COMPONENT_API
    to mono_gc_memmove_atomic.h, but that function is declared in two
    different headers, memfuncs.h and gc-internal-agnostic.h and the
    second one didn't use MONO_COMPONENT_API causing inconsistent linking
    errors on Windows when building dynamic components.
    lateralusX authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    a2665c7 View commit details
    Browse the repository at this point in the history
  16. [Mono] Detail EventPipe sample profiler frames in unmanaged code. (do…

    …tnet#55139)
    
    * Detail sample profiler frames in unmanaged code.
    
    * Include CompileMehtod frame in callstack when JIT:ing code to identify
    frames marked as being in unmanaged code when JIT:ing.
    
    * Add Monitor.Enter into callstack when hitting monitor enter icall to
    identify frames marked as being in unmanaged code due to Monitor contention.
    
    * Include pinvoke frame in (JIT/AOT) to identify frames marked as being
    in unmanaged code while running a pinvoke.
    
    * Identify runtime invoke icall frame on top of callstack and classify
    as being in managed code.
    
    * Include pinvoke wrapper in rundown events.
    lateralusX authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    ca972ed View commit details
    Browse the repository at this point in the history
  17. Update new LoggerMessage.Define APIs, to take LogDefineOptions (d…

    …otnet#54581)
    
    * Change preview overloads, take LogDefineOptions
    
    Related to dotnet#50913
    
    * Apply PR feedback
    
    * Fix compile issue
    maryamariyan authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    be5a950 View commit details
    Browse the repository at this point in the history
  18. compile composite with avx2 on x64 (dotnet#55057)

    * compile composite with avx2 on x64
    
    * fix xml coding style
    mangod9 authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    aeb467e View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    1f547ac View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    331078a View commit details
    Browse the repository at this point in the history
  21. Add llvm ios (dotnet#55222)

    * add LLVM scenario
    
    * add copy to payload
    
    * reverse paths
    
    * fix log path
    
    * Move log fix
    
    * remove extra scenario
    billwert authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    656775f View commit details
    Browse the repository at this point in the history
  22. Resolve ILLink warnings in System.Memory.Data (dotnet#54980)

    The current APIs require unreferenced code, since they call into JsonSerializer without providing JsonTypeInfo.
    
    dotnet#54979 is logged to add "trim compatible" APIs here.
    eerhardt authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    017e16c View commit details
    Browse the repository at this point in the history
  23. Finish migrating System.Drawing.Common to ComWrappers (dotnet#54884)

    * Finish migrating System.Drawing.Common to ComWrappers
    
    This resolves all ILLink warnings in System.Drawing.Common, making it work in a trimmed application.
    eerhardt authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    890fde7 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    971d204 View commit details
    Browse the repository at this point in the history
  25. Test

    MihaZupan committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    c1fa1df View commit details
    Browse the repository at this point in the history
  26. Enable ToBase64Transform.CanTransformMultipleBlocks (dotnet#55055)

    * Enable ToBase64Transform.CanTransformMultipleBlocks
    
    * Address PR feedback
    stephentoub authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    ae5ee8f View commit details
    Browse the repository at this point in the history
  27. Test

    MihaZupan committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    1dc66e7 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    d4b98b9 View commit details
    Browse the repository at this point in the history
  29. Test

    MihaZupan committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    007a5de View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Configuration menu
    Copy the full SHA
    c45b03a View commit details
    Browse the repository at this point in the history
  2. Avoid FileStream allocations in Sockets (dotnet#55232)

    Use File.OpenHandle, as all that's needed is the SafeFileHandle, not the FileStream that wraps it.
    stephentoub authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    61ea22a View commit details
    Browse the repository at this point in the history
  3. Relax chain status for building an invalid chain. (dotnet#55231)

    The chain results can be either PartialChain or NotSignatureValid
    depending on what we get back from the underlying platform. This
    relaxes the test so that both are acceptable.
    vcsjones authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    a285302 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a1bb733 View commit details
    Browse the repository at this point in the history
  5. Test

    MihaZupan committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    109ed5c View commit details
    Browse the repository at this point in the history
  6. Fix race when signaling waitable objects in managed implementation (d…

    …otnet#55200)
    
    * TrySignalToSatisfyWait may invalidate multiple elements of the
      WaitedListNode linked list, if the same object occurs multiple
      times in a single WaitForMultipleObjects call.
    
    * Fixes dotnet#52614
    uweigand authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    9ce467f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c6b61fb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    121bcd1 View commit details
    Browse the repository at this point in the history
  9. [mono] Don't call Assembly.CodeBase directly in RuntimeAssembly.GetNa…

    …me (dotnet#54895)
    
    * [mono] Don't call Assembly.CodeBase directly in RuntimeAssembly.GetName
    
       It's marked as not available in single file apps. Call the underlying get_code_base icall.
    
       Fixes dotnet#54835
    
    * [icall] Use MonoImage:filename for RuntimeAssembly.get_code_base
    
       For bundled asssemblies in single file scenarios, RuntimeAssembly.CodeBase will be null, matching CoreCLR.
    
    * disable codebase test on wasm
    lambdageek authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    fcedb50 View commit details
    Browse the repository at this point in the history
  10. Fix incorrect assert in AbandonExisting test case (dotnet#55198)

    * Handle the case where the "notAbandonedWait" event is not signaled
    uweigand authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    974e1af View commit details
    Browse the repository at this point in the history
  11. Disable folding of implementation-defined casts (dotnet#53782)

    * Enhance the FloatOvfToInt2 test to exercise VN paths
    
    It is not very effective right now because the "bad" combinations of
    types are morphed into helpers too early, but it will be helpful when
    we enable folding outside of the importer for those cases too.
    
    * Enhance the FloatOvfToInt2 test to cover importer
    
    It now fails on Windows x86, where many of the
    previous similar failures were observed.
    
    * Disable the test on Mono
    
    * Re-enable tests disabled against dotnet#13651
    
    * Re-enable tests disabled against dotnet#51346
    
    * Re-enable tests disabled against dotnet#47374
    
    * Disable folding in gtFoldExprConst
    
    * Disable folding in VN
    
    * Temporarily promote the test to Pri0
    
    * Reword the comment
    
    * Move the tests back to Pri1
    
    Where they originally were.
    SingleAccretion authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    527e566 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a789606 View commit details
    Browse the repository at this point in the history
  13. System.Text.Json: Add TimeSpanConverter (dotnet#54186)

    * Added TimeSpanConverter.
    
    * Code review.
    
    * Test tweak.
    
    * Added invalid cases.
    
    * Remove the ToArray call in the case of ValueSequence.
    
    * Support escaped strings in TimeSpanConverter.
    
    * Removed 'g' format fallback.
    
    * Fixed 'h:mm:ss' being accepted by TimeSpanConverter.
    
    * Code review.
    
    * Code review.
    CodeBlanch authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    d5f9544 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    164ce9d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7d0c490 View commit details
    Browse the repository at this point in the history