Some improvements to RF #56659
Some improvements to RF #56659
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue Detailsusually I use RF to see if I get AVs, but with regions it's uncertain if tests are just taking a very long time.
|
| @@ -661,20 +659,11 @@ private static void NoExitPoll() | |||
| } | |||
| internal static void MyDebugBreak(string extraData) | |||
| { | |||
| #if !PROJECTK_BUILD | |||
There was a problem hiding this comment.
Do we still want to keep the variant where PROJECTK_BUILD is not defined?
It looks like the code won't compile (with or without your change) without PROJECTK_BUILD defined.
There was a problem hiding this comment.
yeah, I thought about just getting rid of the define (ie, it's always defined) since I don't see any value of maintaining it. but didn't do it with this PR... feel free to do that if you like.
| waitCnt++; | ||
| } | ||
| } | ||
|
|
||
| // let the user know what tests haven't finished... | ||
| if (_testsRunningCount != 0) | ||
| { | ||
| string msg; | ||
|
|
||
| string msg = String.Format("************Timeout reached************"); |
There was a problem hiding this comment.
The call to String.Format is unnecessary?
There was a problem hiding this comment.
right 😁 that's from some copying/pasting. will get rid of it
| _testsRunningCount, currentAllocatedBytes, (currentAllocatedBytes - lastAllocatedBytes), | ||
| GC.CollectionCount(0), | ||
| GC.CollectionCount(2), | ||
| GC.CollectionCount(2), |
There was a problem hiding this comment.
You called GC.CollectionCount(2) twice, looks like one should use 1 as an argument, or am I wrong?
There was a problem hiding this comment.
indeed it should be 1, thanks for spotting it!! 👍
+ added a maximumWaitTime config default to 10 mins + actually breaks into the debugger when it times out when debugBreakOnTestHang is specified + prints out the progress while we wait so it's obvious if it's hung or just because some tests are taking a long time. example output - [7/30/2021 6:52:26 PM 1] ============current number of tests running 14, allocated 50,040,808,336 so far, 879,122,336 since last; (GC 439:420:420), waited 55s [7/30/2021 6:52:26 PM 1] Still running: DirectedGraph.dll [7/30/2021 6:52:26 PM 1] Still running: LargeObjectAlloc.dll [7/30/2021 6:52:26 PM 1] Still running: LargeObjectAlloc1.dll [7/30/2021 6:52:29 PM 1] Still running: LargeObjectAlloc2.dll
|
failures are unrelated. |
|
thanks @hoyosjs! |
ghost
locked as resolved and limited conversation to collaborators
usually I use RF to see if I get AVs, but with regions it's uncertain if tests are just taking a very long time.
tests are taking a long time. example output -