Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip RuntimeEventSource tests on wasm and android #57890

Merged
3 commits merged into from
Aug 22, 2021
Merged

Skip RuntimeEventSource tests on wasm and android #57890

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55993cc
Skip RuntimeEventSource tests on wasm and android
agocke Aug 22, 2021
eff7067
Skip tests without using issues.targets
agocke Aug 22, 2021
4776871
Disable test for mono
agocke Aug 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2361,6 +2361,9 @@


<ItemGroup Condition=" '$(TargetArchitecture)' == 'wasm' " >
<ExcludeList Include="$(XunitTestBinBase)/tracing/eventcounter/runtimeeventsource/runtimeeventsource*">
<Issue>AppContext switch events are not available on mono Android and wasm</Issue>
</ExcludeList>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious what's special about these two, e.g. they are available on iOS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, still investigating. I suspect it doesn't work on iOS either, but we may not run those tests.

Copy link
Member Author

@agocke agocke Aug 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah -- it looks like the runtime tests are only run on Mono for Android and wasm. I don't even see x64 there, which suprises me.

I'm going to blanket disable this on Mono for now. It wasn't a requirement and I would want to do a lot more work before stating this should work in any Mono environment.

<ExcludeList Include="$(XunitTestBinBase)/JIT/Intrinsics/TypeIntrinsics_r/**">
<Issue>https:/dotnet/runtime/issues/54867</Issue>
</ExcludeList>
Expand Down Expand Up @@ -2690,6 +2693,9 @@
</ItemGroup>

<ItemGroup Condition=" $(TargetOS) == 'Android' " >
<ExcludeList Include="$(XunitTestBinBase)/tracing/eventcounter/runtimeeventsource/runtimeeventsource*">
<Issue>AppContext switch events are not available on mono Android and wasm</Issue>
</ExcludeList>
<ExcludeList Include = "$(XunitTestBinBase)/baseservices/TieredCompilation/**">
<Issue>No crossgen folder under Core_Root</Issue>
</ExcludeList>
Expand Down