[release/6.0] Cleaned up version of earlier PR #48601. #58544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Remove changes for the heap_hard_limit case - we'll do those later. Fixed another place where I had called generation_sizes instead of generation_size.
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #56772 to release/6.0 /cc @PeterSolMS Customer ImpactTestingRisk
|
jeffschwMSFT
approved these changes
Sep 2, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #56772 to release/6.0
/cc @PeterSolMS
Customer Impact
This is a port of the GCConserveMemory setting that we implemented in .NET Framework. Substantial savings in working set have been seen in testing without too much increase in GC pause time.
Testing
This has seen performance testing using GCPerfSim and real world scenarios.
Risk
Low - there is no change in behavior unless the setting is actually used. Also, we have not seen negative impact in .NET Framework.