[API Implementation]: SafeFileHandle overloads for SetCreationTime, SetLastAccessTime, SetLastWriteTime

src/libraries/Common/src/Interop/Windows/Kernel32/Interop.WIN32_FILE_ATTRIBUTE_DATA.cs

@@ -23,16 +23,6 @@ internal void PopulateFrom(ref WIN32_FIND_DATA findData)
  nFileSizeHigh = findData.nFileSizeHigh;
  nFileSizeLow = findData.nFileSizeLow;
  }
-
- internal void PopulateFrom(in BY_HANDLE_FILE_INFORMATION fileInformationData)
- {
- dwFileAttributes = (int)fileInformationData.dwFileAttributes;
- ftCreationTime = fileInformationData.ftCreationTime;
- ftLastAccessTime = fileInformationData.ftLastAccessTime;
- ftLastWriteTime = fileInformationData.ftLastWriteTime;
- nFileSizeHigh = fileInformationData.nFileSizeHigh;
- nFileSizeLow = fileInformationData.nFileSizeLow;
- }
  }
  }
 }

src/libraries/Common/src/System/IO/FileSystem.Attributes.Windows.cs

@@ -112,19 +112,6 @@ internal static int FillAttributeInfo(string? path, ref Interop.Kernel32.WIN32_F
  return errorCode;
  }
 
- internal static int FillAttributeInfo(SafeFileHandle fileHandle, ref Interop.Kernel32.WIN32_FILE_ATTRIBUTE_DATA data)
- {
- if (!Interop.Kernel32.GetFileInformationByHandle(
- fileHandle,
- out Interop.Kernel32.BY_HANDLE_FILE_INFORMATION fileInformationData))
- {
- return Marshal.GetLastWin32Error();
- }
-
- data.PopulateFrom(fileInformationData);
- return Interop.Errors.ERROR_SUCCESS;
- }
-
  internal static bool IsPathUnreachableError(int errorCode)
  {
  switch (errorCode)

src/libraries/System.IO.FileSystem.AccessControl/src/System.IO.FileSystem.AccessControl.csproj

@@ -46,8 +46,6 @@
  Link="Common\Interop\Windows\Interop.GET_FILEEX_INFO_LEVELS.cs" />
  <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.GetFileAttributesEx.cs"
  Link="Common\Interop\Windows\Interop.GetFileAttributesEx.cs" />
- <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.GetFileInformationByHandle.cs"
- Link="Common\Interop\Windows\Interop.GetFileInformationByHandle.cs" />
  <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.GetFullPathNameW.cs"
  Link="Common\Interop\Windows\Interop.GetFullPathNameW.cs" />
  <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.GetLongPathNameW.cs"
@@ -62,8 +60,6 @@
  Link="Common\Interop\Windows\Interop.SetThreadErrorMode.cs" />
  <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.WIN32_FILE_ATTRIBUTE_DATA.cs"
  Link="Common\Interop\Windows\Interop.WIN32_FILE_ATTRIBUTE_DATA.cs" />
- <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.BY_HANDLE_FILE_INFORMATION.cs" 
- Link="Common\Interop\Windows\Interop.BY_HANDLE_FILE_INFORMATION.cs" />
  <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.WIN32_FIND_DATA.cs"
  Link="Common\Interop\Windows\Interop.WIN32_FIND_DATA.cs" />
  <Compile Include="$(CoreLibSharedDir)System\IO\DisableMediaInsertionPrompt.cs"

src/libraries/System.IO.FileSystem/tests/File/GetSetAttributes_SafeFileHandle.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using Microsoft.Win32.SafeHandles;
+using Xunit;
 
 namespace System.IO.Tests
 {
@@ -27,5 +28,12 @@ protected override void SetAttributes(string path, FileAttributes attributes)
  using SafeFileHandle fileHandle = OpenFileHandle(path, FileAccess.ReadWrite);
  File.SetAttributes(fileHandle, attributes);
  }
+
+ [Fact]
+ public void NullArgumentValidation()
+ {
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.GetAttributes(default(SafeFileHandle)!));
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.SetAttributes(default(SafeFileHandle)!, (FileAttributes)0));
+ }
  }
 }

src/libraries/System.IO.FileSystem/tests/File/GetSetTimes_SafeFileHandle.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using Microsoft.Win32.SafeHandles;
+using Xunit;
 
 namespace System.IO.Tests
 {
@@ -89,5 +90,27 @@ protected override DateTime GetLastWriteTimeUtc(string path)
  using SafeFileHandle fileHandle = OpenFileHandle(path, FileAccess.Read);
  return File.GetLastWriteTimeUtc(fileHandle);
  }
+
+ [Fact]
+ public void NullArgumentValidation()
+ {
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.GetCreationTime(default(SafeFileHandle)!));
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.SetCreationTime(default(SafeFileHandle)!, DateTime.Now));
+
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.GetCreationTimeUtc(default(SafeFileHandle)!));
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.SetCreationTimeUtc(default(SafeFileHandle)!, DateTime.Now));
+
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.GetLastAccessTime(default(SafeFileHandle)!));
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.SetLastAccessTime(default(SafeFileHandle)!, DateTime.Now));
+
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.GetLastAccessTimeUtc(default(SafeFileHandle)!));
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.SetLastAccessTimeUtc(default(SafeFileHandle)!, DateTime.Now));
+
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.GetLastWriteTime(default(SafeFileHandle)!));
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.SetLastWriteTime(default(SafeFileHandle)!, DateTime.Now));
+
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.GetLastWriteTimeUtc(default(SafeFileHandle)!));
+ Assert.Throws<ArgumentNullException>("fileHandle", static () => File.SetLastWriteTimeUtc(default(SafeFileHandle)!, DateTime.Now));
+ }
  }
 }