Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime support for ref fields #63985

Merged
merged 27 commits into from
Jan 23, 2022
Merged

Add runtime support for ref fields #63985

merged 27 commits into from
Jan 23, 2022

Commits on Jan 19, 2022

  1. Add runtime support for ref fields

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    4ae810d View commit details
    Browse the repository at this point in the history

  2. Update Reflection.Emit tests to validate ref fields.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    34933ac View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary addition in ASSERT.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    6339127 View commit details
    Browse the repository at this point in the history

  4. Mono should throw TypeLoadException for invalid ref field. 

    Test skips Mono for loading invalid type with a ref field.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    5fc6174 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. coreclr/

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    2792c74 View commit details
    Browse the repository at this point in the history

  2. libraries/

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    7a2d818 View commit details
    Browse the repository at this point in the history

  3. mono/

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    4ff87f9 View commit details
    Browse the repository at this point in the history

  4. tests/ 

    Add test for TypedReference as a ref field.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    eafc0a8 View commit details
    Browse the repository at this point in the history

  5. mono/ 

    Handle error cases in type loading for ref fields.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    acff92a View commit details
    Browse the repository at this point in the history

  6. tests/

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    f2db03b View commit details
    Browse the repository at this point in the history

  7. mono/ 

    Remove IsByRef check for opcode emit.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    091a48b View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/main' into ref_field_support 

    # Conflicts:
#	src/mono/mono/metadata/class-init.c
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    78fbfd0 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. mono/ 

    Remove block for byref field.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    a4604e6 View commit details
    Browse the repository at this point in the history

  2. mono/ 

    Validate ref fields in SRE.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    f2ec70c View commit details
    Browse the repository at this point in the history

  3. mono/ 

    Return error when class init fails during TYPEDEF, TYPEREF, TYPESPEC.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    3702e57 View commit details
    Browse the repository at this point in the history

  4. mono/ 

    Using helper instead of checking field.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    87a3e30 View commit details
    Browse the repository at this point in the history

  5. mono/ 

    In SRE, propagate the IsByRefLike value during Type creation.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    4fe2045 View commit details
    Browse the repository at this point in the history

  6. Add test for SRE activation of types with ref fields.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    66e7747 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2022

  1. libraries/ 

    Update TypeBuilder tests.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    f493441 View commit details
    Browse the repository at this point in the history

  2. coreclr/ 

    Remove IsByRefLike checks in Reflection Emit code paths.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    9804d2a View commit details
    Browse the repository at this point in the history

  3. Exclude the RefFields tests from running on llvmfullaot

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    166e4f2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ref_field_support

    @AaronRobinsonMSFT
    AaronRobinsonMSFT authored Jan 22, 2022
    Configuration menu
    Copy the full SHA
    e1b2c07 View commit details
    Browse the repository at this point in the history

  5. Instead of dropping the byref, compute a token from a typespec.

    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    d6e7c0f View commit details
    Browse the repository at this point in the history

  6. mono/ 

    Remove checks in SRE to match CoreCLR behavior and unit tests.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    3059e77 View commit details
    Browse the repository at this point in the history

  7. coreclr/ 

    Add back assert.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    8dca52e View commit details
    Browse the repository at this point in the history

  8. mono/ 

    Perform ref field validation in native SRE type loading logic.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    6a5ac57 View commit details
    Browse the repository at this point in the history

  9. mono/ 

    Move IsByRefLike decision into native SRE code.
    @AaronRobinsonMSFT
    AaronRobinsonMSFT committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    62e06ed View commit details
    Browse the repository at this point in the history