Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGO: Add new tiers #70941

Merged
merged 64 commits into from
Oct 26, 2022
Merged

PGO: Add new tiers #70941

merged 64 commits into from
Oct 26, 2022

Commits on Jun 23, 2022

  1. R2R -> InstrumentedTier0 for hot R2R methods

    @EgorBo
    EgorBo committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    07de069 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into tier0instrumented

    @EgorBo
    EgorBo committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    a7bbfaf View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Oops, it turns out that I didn't properly patch re-used callcountingstub

    @EgorBo
    EgorBo committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    4b4967b View commit details
    Browse the repository at this point in the history

  2. remove TieredPGO

    @EgorBo
    EgorBo committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    1392368 View commit details
    Browse the repository at this point in the history

  3. fix bug in the importer

    @EgorBo
    EgorBo committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    1a41355 View commit details
    Browse the repository at this point in the history

  4. Add ability to instrument optimized code

    @EgorBo
    EgorBo committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    4828f3e View commit details
    Browse the repository at this point in the history

  5. fix 32bit

    @EgorBo
    EgorBo committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    1fa264b View commit details
    Browse the repository at this point in the history

  6. fix ret type

    @EgorBo
    EgorBo committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    71928f3 View commit details
    Browse the repository at this point in the history

  7. Clean up

    @EgorBo
    EgorBo committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    127b7d8 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of github.com:dotnet/runtime into tier0instrumented

    @EgorBo
    EgorBo committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    2cee8a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. Clean up

    @EgorBo
    EgorBo committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    911af8a View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2022

  1. test fix

    @EgorBo
    EgorBo committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    0316842 View commit details
    Browse the repository at this point in the history

  2. test2

    @EgorBo
    EgorBo committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    2022e68 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into new-tier 

    # Conflicts:
#	src/coreclr/inc/clrconfigvalues.h
#	src/coreclr/jit/fginline.cpp
    @EgorBo
    EgorBo committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    246dd95 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. Address feedback

    @EgorBo
    EgorBo committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    3a718af View commit details
    Browse the repository at this point in the history

  2. Don't re-use callcountingstubs for now

    @EgorBo
    EgorBo committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    41733fe View commit details
    Browse the repository at this point in the history

  3. Clean up

    @EgorBo
    EgorBo committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    21c8f6e View commit details
    Browse the repository at this point in the history

  4. Address feedback

    @EgorBo
    EgorBo committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    f37012d View commit details
    Browse the repository at this point in the history

  5. Address feedback

    @EgorBo
    EgorBo committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    db9c71d View commit details
    Browse the repository at this point in the history

  6. Add docs

    @EgorBo
    EgorBo committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    59b2bc9 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. Enable other strategies

    @EgorBo
    EgorBo committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    ca5c347 View commit details
    Browse the repository at this point in the history

  2. Clean up

    @EgorBo
    EgorBo committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    a6318a0 View commit details
    Browse the repository at this point in the history

  3. Fix GetInitialOptimizationTier

    @EgorBo
    EgorBo committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    f75e289 View commit details
    Browse the repository at this point in the history

  4. Enable optimized Instrumentations

    @EgorBo
    EgorBo committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    e9e12ea View commit details
    Browse the repository at this point in the history

  5. Update diagram

    @EgorBo
    EgorBo committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    81496c4 View commit details
    Browse the repository at this point in the history

  6. Fix assert

    @EgorBo
    EgorBo committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    be329a1 View commit details
    Browse the repository at this point in the history

  7. Update

    @EgorBo
    EgorBo committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    48e375e View commit details
    Browse the repository at this point in the history

  8. Add test

    @EgorBo
    EgorBo committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    1ac3e19 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2022

  1. Update clrconfigvalues.h 

    CI Test
    @EgorBo
    EgorBo authored Jul 17, 2022
    Configuration menu
    Copy the full SHA
    f6b457a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into new-tier

    @EgorBo
    EgorBo committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    7b9e5d4 View commit details
    Browse the repository at this point in the history

  3. Update clrconfigvalues.h

    @EgorBo
    EgorBo authored Jul 17, 2022
    Configuration menu
    Copy the full SHA
    cbddf5b View commit details
    Browse the repository at this point in the history

  4. Update clrconfigvalues.h

    @EgorBo
    EgorBo authored Jul 17, 2022
    Configuration menu
    Copy the full SHA
    9345815 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. Merge branch 'new-tier' of github.com:EgorBo/runtime-1 into new-tier

    @EgorBo
    EgorBo committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    86523e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into new-tier 

    # Conflicts:
#	src/coreclr/vm/eeconfig.cpp
#	src/coreclr/vm/prestub.cpp
    @EgorBo
    EgorBo committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    6a0c05c View commit details
    Browse the repository at this point in the history

  3. Resolve conflicts, address feedback

    @EgorBo
    EgorBo committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    a073ed7 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Koundinya Veluri <[email protected]>
    @EgorBo @kouvel
    EgorBo and kouvel authored Aug 6, 2022
    Configuration menu
    Copy the full SHA
    75da822 View commit details
    Browse the repository at this point in the history

  5. Remove InstrumentedTiers_strat4.csproj

    @EgorBo
    EgorBo committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    e83eb68 View commit details
    Browse the repository at this point in the history

  6. Address feedback

    @EgorBo
    EgorBo committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    b1f4d2e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'new-tier' of github.com:EgorBo/runtime-1 into new-tier

    @EgorBo
    EgorBo committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    acdce3d View commit details
    Browse the repository at this point in the history

  8. update DynamicPgo-InstrumentedTiers.md

    @EgorBo
    EgorBo committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    27f7228 View commit details
    Browse the repository at this point in the history

  9. Clean up

    @EgorBo
    EgorBo committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    2e478c0 View commit details
    Browse the repository at this point in the history

  10. Clean up

    @EgorBo
    EgorBo committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    557ec0c View commit details
    Browse the repository at this point in the history

  11. clean up

    @EgorBo
    EgorBo committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    48cf945 View commit details
    Browse the repository at this point in the history

  12. Rename arg in AsyncPromoteToTier1

    @EgorBo
    EgorBo committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    ca491a0 View commit details
    Browse the repository at this point in the history

  13. Address feedback

    @EgorBo
    EgorBo committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    25bddf0 View commit details
    Browse the repository at this point in the history

  14. Address feedback

    @EgorBo
    EgorBo committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    f777274 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2022

  1. Address feedback

    @EgorBo
    EgorBo committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    13e1211 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into new-tier

    @EgorBo
    EgorBo committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    15c0e2d View commit details
    Browse the repository at this point in the history

  3. Fix issues found during testing

    @EgorBo
    EgorBo committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    3d88252 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into new-tier 

    # Conflicts:
#	src/coreclr/jit/importer.cpp
    @EgorBo
    EgorBo committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    60a77e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Simplify PR, get rid of strategies

    @EgorBo
    EgorBo committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    df19c68 View commit details
    Browse the repository at this point in the history

  2. Enable TieredPGO_InstrumentOnlyHotCode by default

    @EgorBo
    EgorBo committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    f46679c View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into new-tier

    @EgorBo
    EgorBo committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    4d77f85 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Fix an assert in optimized instrumented tier

    @EgorBo
    EgorBo committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    c9bd079 View commit details
    Browse the repository at this point in the history

  2. fix osr tests

    @EgorBo
    EgorBo committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    d3f205b View commit details
    Browse the repository at this point in the history

  3. Update docs

    @EgorBo
    EgorBo committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    ef4ae58 View commit details
    Browse the repository at this point in the history

  4. Update DynamicPgo-InstrumentedTiers.md

    @EgorBo
    EgorBo authored Oct 18, 2022
    Configuration menu
    Copy the full SHA
    7fd0749 View commit details
    Browse the repository at this point in the history

  5. Address feedback

    @EgorBo
    EgorBo committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    c4395f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into new-tier

    @EgorBo
    EgorBo committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    7fbcf17 View commit details
    Browse the repository at this point in the history

  2. Address Andy's feedback

    @EgorBo
    EgorBo committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    a183996 View commit details
    Browse the repository at this point in the history

  3. Disable edge-profiling with a comment

    @EgorBo
    EgorBo committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    ff471e1 View commit details
    Browse the repository at this point in the history

  4. fix assert

    @EgorBo
    EgorBo committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    b202b9f View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Update docs/design/features/DynamicPgo-InstrumentedTiers.md 

    Co-authored-by: Andy Ayers <[email protected]>
    @EgorBo @AndyAyersMS
    EgorBo and AndyAyersMS authored Oct 24, 2022
    Configuration menu
    Copy the full SHA
    64eb6df View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Fix "mb" in the doc, add one more example to the "perf impact" section

    @EgorBo
    EgorBo committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    07339dc View commit details
    Browse the repository at this point in the history