Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Modify workload to pick threading runtime packs #72412

Merged
merged 7 commits into from
Jul 27, 2022

Commits on Jul 18, 2022

  1. [wasm] Modify workload to pick threading runtime packs

    This change adds the 2 wasm threading runtime packs to the wasm workload. In order for a threading runtime pack to be chosen, WorkloadManifest.targets is also modified to override the runtime pack name when the following props are set:
    
    WasmEnableThreads - full threading support and will load Microsoft.NETCore.App.Runtime.multithread.Mono.browser-wasm
    
    WasmEnablePerfTrace - runtime only threading support and will load Microsoft.NETCore.App.Runtime.perftrace.Mono.browser-wasm
    Steve Pfister committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    279bb62 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Add error condition when both WasmEnableThreading and WasmEnablePerfT…

    …race are true
    Steve Pfister committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    0f9e3b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. Configuration menu
    Copy the full SHA
    d6e57a4 View commit details
    Browse the repository at this point in the history
  2. [wasm] Wasm.Build.Tests: add support for multiple runtime packs

    - Runtime pack nugets other than the one that gets built might not be
    available. In that case, we copy the only one available as the missing
    ones.
        - This is useful for local builds, allowing running Wasm.Build.Tests
          without having to build all 3 runtimes.
        - This is enabled for CI also, in this commit. But once CI gets the
          ability to fetch the other runtime packs, this will change.
    radical committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    6efec93 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Configuration menu
    Copy the full SHA
    ec9f701 View commit details
    Browse the repository at this point in the history
  2. [wasm] Wasm.Build.Tests: build runtime pack nugets with different names

    - The earlier approach of simply making copies of the existing runtime
    pack nuget with different names doesn't work, and `dotnet workload
    install` rejects it.
    
    ```
      Installing pack Microsoft.NETCore.App.Runtime.Mono.multithread.browser-wasm version 7.0.0-ci...
      Workload installation failed. Rolling back installed packs...
    ```
    
    Instead, now we build the missing nugets from the project with different
    values for `$(MonoWasmBuildVariant)`.
    
    - this handles local builds, and incremental builds also
    - To skip building the missing nugets, for example, when you have all of
    them available, then set `WasmSkipMissingRuntimePackBuild=true`.
    radical committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    0fa442f View commit details
    Browse the repository at this point in the history
  3. fix comment

    radical committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    32d220c View commit details
    Browse the repository at this point in the history