Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotating System.Diagnostics.DiagnosticSource on AOT #72706

Merged
merged 7 commits into from
Aug 3, 2022

Conversation

LakshanF
Copy link
Member

@LakshanF LakshanF commented Jul 23, 2022

There are 2 leaf level warnings

  • In Internal class PropertySpec, FetcherForProperty has 2 MakeGenericType warnings. The RDC warnings are propagated for root APIs in the assembly with the following exceptions

OnEventWritten, similar to the RUC suppression message, DiagnosticSource.Write is now annotated with RDC

OnActivityStarted, since Activity is a reference type and MakeGenericType is safe

OnActivityStopped, since Activity is a reference type and MakeGenericType is safe.

AllListeners get method since the dangerous HttpHandlerDiagnosticListener static is only enabled in older .NET FX

@LakshanF
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LakshanF LakshanF merged commit 1926f09 into dotnet:main Aug 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants