Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable distributed transactions test #78468

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

roji
Copy link
Member

@roji roji commented Nov 16, 2022

@ghost
Copy link

ghost commented Nov 16, 2022

Tagging subscribers to this area: @roji
See info in area-owners.md if you want to be subscribed.

Issue Details

See #77241 (comment)

Author: roji
Assignees: roji
Labels:

area-System.Transactions

Milestone: -

@@ -529,6 +529,7 @@ public void ImplicitDistributedTransactions_cannot_be_changed_after_being_set()
}

[ConditionalFact(nameof(IsRemoteExecutorSupportedAndNotNano))]
[ActiveIssue("https:/dotnet/runtime/issues/77241")]
public void ImplicitDistributedTransactions_cannot_be_changed_after_being_read_as_true()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the ImplicitDistributedTransactions_cannot_be_changed_after_being_read_as_false right below this also be disabled?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing a test failure for that in #77241, did I miss another failure somewhere?

I agree that the failure likely isn't specifically related to ImplicitDistributedTransactions_cannot_be_changed_after_being_read_as_true, and part of the reason for disabling it is to see if the failure slips to another test, which may provide a bit more information... Any thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any failures for that one either so that sounds good to me.

@roji roji merged commit 0f412b1 into dotnet:main Nov 16, 2022
@roji roji deleted the DisableOleTxTest branch November 16, 2022 20:21
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants