decorate SequenceEqual with AggressiveOptimization #79645
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is good idea or not, I'm looking for feedback.
We found out with @ilonatommy that
string.Normalize
could be slow when running on Mono interp (in browser).The reason is that interp would tier up and optimize the
SequenceEqual
method only after 1000 calls.If we add
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
the Mono interpreter would optimize it right away.Many of the other methods in the
SpanHelpers
are decorated same way. IsSequenceEqual
just missing the attribute ?At this point I don't know what is customer impact.