Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/multi server ldap binding linux #79657

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

iinuwa
Copy link
Contributor

@iinuwa iinuwa commented Dec 14, 2022

Fixes #79653.

There are changes that technically affect Windows, but should be a no-op. However, I am unable to test them because I don't have access to a Windows machine. I am also not sure if this particular test runs in CI.

If someone could build this fork and run the following test, I'd appreciate it:

docker run -p 1389:1389 -e ROOT_USER_DN='cn=admin,dc=example,dc=com' -e BASE_DN='dc=example,dc=com' -e ROOT_PASSWORD=password -d openidentityplatform/opendj
cd src/libraries/System.DirectoryServices.Protocols/tests
$env:LDAP_TEST_SERVER_INDEX = 0
dotnet test

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 14, 2022
@ghost
Copy link

ghost commented Dec 14, 2022

Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #79653.

There are changes that technically affect Windows, but should be a no-op. However, I am unable to test them because I don't have access to a Windows machine. I am also not sure if this particular test runs in CI.

If someone could build this fork and run the following test, I'd appreciate it:

docker run -p 1389:1389 -e ROOT_USER_DN='cn=admin,dc=example,dc=com' -e BASE_DN='dc=example,dc=com' -e ROOT_PASSWORD=password -d openidentityplatform/opendj
cd src/libraries/System.DirectoryServices.Protocols/tests
$env:LDAP_TEST_SERVER_INDEX = 0
dotnet test
Author: iinuwa
Assignees: -
Labels:

area-System.DirectoryServices

Milestone: -

Copy link
Member

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iinuwa changes LGTM.

@buyaa-n
Copy link
Member

buyaa-n commented Dec 28, 2022

If someone could build this fork and run the following test, I'd appreciate it:

Verified the fix on Windows and Linux. The failures unrelated and known, merging

@buyaa-n buyaa-n merged commit 620239a into dotnet:main Dec 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2023
@iinuwa iinuwa deleted the fix/multi-server-ldap-binding-linux branch July 29, 2024 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.DirectoryServices community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot Bind LdapConnection to multiple servers on Linux
2 participants