Handle crash when [out] parameter of type Intptr* is passed to delegate #79763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a delegate is passed an [out] parameter of type "intptr *" it will crash since this data type is not handled in emit_managed_wrapper_ilgen. This will lead to a crash. With this fix [out] parameter of type "Intptr *" is handled after adding an addition case statement to handle MONO_TYPE_PTR in emit_managed_wrapper_ilgen.
giritrivedi
requested review from
vargaz,
lambdageek and
thaystg
as code owners
ghost
added
the
community-contribution
|
|
|
Hi @vargaz , @lambdageek , @thaystg |
vargaz
approved these changes
Dec 23, 2022
|
Hi, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a delegate is passed an [out] parameter of type "intptr *" it will crash since this data type is not handled in emit_managed_wrapper_ilgen. This will lead to a crash. With this fix [out] parameter of type "Intptr *" is handled after adding an addition case statement to handle MONO_TYPE_PTR in emit_managed_wrapper_ilgen. Supporting UT is added.