[wasm] Always allocate when computing temp path #81085
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wasm implementation of
__randname
uses pointer address as another entry into the randomness.https:/emscripten-core/emscripten/blob/085fe968d43c7d3674376f29667d6e5f42b24966/system/lib/libc/musl/src/temp/__randname.c#L13
We may get the same random name if the same pointer passed twice before the clock ticks. The issue in the upstream repository is emscripten-core/emscripten#18591.
We have decided to take the simplest solution at the moment and consider a better one as part of the WASI file system implementation #81210
Fixes #73721