[NativeAOT] Do not strip exported symbols from executables on Apple platforms #85293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Details
However, this breaks a special use case on Apple platforms when an executable dynamically looks-up symbols in the current executable image (self-referencing) reported here: #85139 (comment) This PR:
cc: @kotlarmilos
|
am11
approved these changes
Apr 25, 2023
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated
Show resolved
Hide resolved
SamMonoRT
approved these changes
Apr 25, 2023
jkotas
added a commit
to jkotas/runtime
that referenced
this pull request
May 1, 2023
… Apple platforms (dotnet#85293)" This reverts commit 32ecd85.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StripSymbolsproject property is now set by default when building with NativeAOT: #85139However, this breaks a special use case on Apple platforms when an executable dynamically looks-up symbols in the current executable image (self-referencing) reported here: #85139 (comment)
This PR:
StripFlagfor this special use case, which will ignore exported symbols when stripping the executableStripFlaginto_StripFlagas it is an internal propertycc: @kotlarmilos