Remove InstrumentRecorder class #87873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dotnet-issue-labeler
bot
added
needs-area-label
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
tarekgh
added
area-System.Diagnostics.Metric
and removed
needs-area-label
geeknoid
approved these changes
Jun 21, 2023
noahfalk
approved these changes
Jun 21, 2023
| InstrumentRecorder<int> recorder = new InstrumentRecorder<int>(counter); | ||
|
|
||
| using MeterListener listener = new MeterListener(); | ||
| listener.InstrumentPublished = (instrument, theListener) => |
There was a problem hiding this comment.
This works and I'm fine if you merge it this way, but a simpler option is:
using MeterListener listener = new MeterListener();
int lastMeasurement = 0;
listener.SetMeasurementEventCallback<int>((inst, measurement, tags, state) => lastMeasurement = measurement);
listener.EnableMeasurementEvents(counter, null);There is no requirement to use publishing events if you already know the counter you want to listen to.
There was a problem hiding this comment.
I'll fix this in another PR. Thanks!
3 tasks
ericstj
approved these changes
Jun 21, 2023
I can add something to dotnet/core#8437 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing InstrumentRecorder from the runtime. MetricCollector can be used instead.