Document new STJ diagnostics and fix diagnostic id conflicts. #87980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFollowing up on #87950 (comment) this PR documents the recently added diagnostics to STJ. It also addresses a couple of conflicts, since it appears that they overran the pre-allocated id range for STJ. This PR pre-allocates a separate block between
|
eiriktsarpalis
commented
Jun 23, 2023
| | __`SYSLIB1216`__ | *_`SYSLIB1214`-`SYSLIB1219` reserved for Microsoft.Extensions.Options.SourceGeneration.* | | ||
| | __`SYSLIB1217`__ | *_`SYSLIB1214`-`SYSLIB1219` reserved for Microsoft.Extensions.Options.SourceGeneration.* | | ||
| | __`SYSLIB1218`__ | *_`SYSLIB1214`-`SYSLIB1219` reserved for Microsoft.Extensions.Options.SourceGeneration.* | | ||
| | __`SYSLIB1219`__ | *_`SYSLIB1214`-`SYSLIB1219` reserved for Microsoft.Extensions.Options.SourceGeneration.* | |
There was a problem hiding this comment.
cc @tarekgh I bumped the upper bound for the Options SG to SYSLIB1219 so that the STJ block can start at SYSLIB1220
stephentoub
reviewed
Jun 24, 2023
src/libraries/System.Text.Json/gen/JsonSourceGenerator.DiagnosticDescriptors.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Jun 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #87950 (comment) this PR documents the recently added diagnostics to STJ. It also addresses a couple of conflicts, since it appears that they overran the pre-allocated id range for STJ. This PR pre-allocates a separate block between
SYSLIB1220-SYSLIB229for use by STJ.cc @layomia